[Bug 153463] [PATCH] Make Kompare build/work in KDE 4.0 SVN (3.96.2)

Kevin Kofler kevin.kofler at chello.at
Mon Dec 10 12:52:07 CET 2007


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153463         
kevin.kofler chello at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22375|0                           |1
        is obsolete|                            |



------- Additional Comments From kevin.kofler chello at  2007-12-10 12:52 -------
Created an attachment (id=22443)
 --> (http://bugs.kde.org/attachment.cgi?id=22443&action=view)
Fix Kompare in KDE 4 (rev 5)

New patch against trunk:
* backports the KompareSplitter from 3_way_kompare branch (the backported
KompareSplitter combines KompareSplitter and KompareFileSplitter from
3_way_kompare because we don't have a KompareDirSplitter in trunk), eliminates
QSplitter hackery (no more forward-port of the Qt 3 QSplitter, no more (ab)use
of qlayoutengine_p.h). Yes, I tested this and found no regressions.
* fixes a warning about an undefined signal (KUrlSelecter::urlSelected(const
QString &)). This now passes a const KUrl & instead, but the signal handler
appears not to be needed at all anymore (files are already recognized as such
and displayed without the file:// prefix, so no need to hack the URL string for
that anymore), so I just removed it.


More information about the Kompare-devel mailing list