[Bug 153463] [PATCH] Make Kompare build/work in KDE 4.0 SVN (3.96.2)

[Kevin Kofler]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153463         




------- Additional Comments From kevin.kofler chello at  2007-12-08 07:25 -------
On Saturday 08 December 2007, Jeff Snyder wrote:
> I noticed you mentioned the splitter in some detail - and I dearly wish
> we'd talked sooner - because you seem to be developing against something
> less than the head of 3_way_kompare in svn. I did a significant bit of
> porting at akademy and shortly afterwards earlier this year which you
> seem to be missing.
> The head of 3_way_kompare has KompareSplitter ported to Qt4's qsplitter,
> which has the features needed to do what kompare wants (partly at my
> request). The code's far cleaner, ridding kompare of all the hacks which
> I made in kde3 and you've now brought forward into kde4.


See, I have no doubt the 3_way_kompare branch is the right code base to start 
from long term (KDE 4.1+). However, there is that TODO list of things needing 
to be done there, and I wanted to have a working Kompare as soon as possible, 
thinking both of the KDE 4.0.0 release in January and the Fedora 9 release in 
April.

I'll be entirely happy if that codebase gets replaced by a working 
3_way_kompare, I'm also willing to help making that happen as my time permits 
(do note that I have several other projects to work on though!), but right 
now my priority was having something which _works_. ;-) And that's what I've 
got now after 2 nights of work.

Don't get me wrong, I know having clean code is important long term and I know 
my straight port of the current kdesdk/kompare trunk definitely isn't clean 
code (there's not just the splitter hacks, but also lots of Qt3Support and 
kde3support junk), however I also think there is a phase in a release cycle 
in which the focus really has to be on getting things working. You may 
disagree, but my personal opinion is that it's better to have my hacked-up 
Kompare in 4.0 than no Kompare at all, it can always be replaced by a cleaner 
version from 3_way_kompare branch in 4.1, can't it?

        Kevin Kofler