[Bug 153463] [PATCH] Make Kompare build/work in KDE 4.0 SVN (3.96.2)

[Kevin Kofler]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153463         
kevin.kofler chello at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22344|0                           |1
        is obsolete|                            |



------- Additional Comments From kevin.kofler chello at  2007-12-05 08:12 -------
Created an attachment (id=22345)
 --> (http://bugs.kde.org/attachment.cgi?id=22345&action=view)
Fix Kompare in KDE 4 (rev 2)

This version fixes the 2 bugs related to blending URLs with diffs above. (The
crasher was due to using long-lived iterators on a QStringList, which no longer
works with the QList-based implementation of QStringList, I fixed it by copying
the QStringList into a QLinkedList<QString>.) It also fixes the Levenshtein
computation (the inline difference marking) to actually work. Who ever thought
it was a good idea to change this:
	const QChar* sq = s.unicode();
	const QChar* dq = d.unicode();
...
		dj = dq[ j ];

		for ( i = 1; i < m; ++i )
		{
			si = sq[ i ];
to this:
		dj = QString(dq[ j ]).toInt();

		for ( i = 1; i < m; ++i )
		{
			si = QString(sq[ i ]).toInt();
??? I fixed it to:
		dj = dq[j].unicode();

		for ( i = 1; i < m; ++i )
		{
			si = sq[i].unicode();

What's still broken though is the layouts in the startup and preferences
dialogs (the KPageDialogs).