[Bug 116718] patch: add bzr diff file support

[Felix Berger]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=116718         




------- Additional Comments From bflat1 gmx net  2005-11-23 16:51 -------
On Tuesday 22 November 2005 23:56, Jeff Snyder wrote:

> The patch looks like it'll match anything that doesn't match the other
> unified diff recognisers and consider it to be a bzr diff.. then parses the
> header and throws away the filenames.


Don't know what you mean exactly. BzrDiffParser is only constructed and used 
for parsing, if the fileformat has been recognized in 
Parser::determineGenerator(const QStringList&) and the BzrDiffParser passes 
the recognized filenames to the constructor DiffModel(const QString&, const 
QString&).

> Unless there is some special identifier to pick out bzr diffs, or special
> data to be extracted from their headers, I'd rather just fix up the unified
> diff parser to not insist on the presence of timestamps/revisions instead.
> (this would also fix 116637 and its duplicates)


Sounds good, unless you support file renames somehow, see attached bzr diff.

Felix