[Knode-devel] [Bug 72500] KNode considers "280" response an error

[Roberto Teixeira]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
      
http://bugs.kde.org/show_bug.cgi?id=72500      
maragato at kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From maragato at kde.org  2004-01-13 18:28 -------
Subject: kdepim/knode

CVS commit by maragato: 

Don't just test for 200 and 201 as command results. Read all 2xx results as ok (RFC977)

CCMAIL: 72500-done at bugs.kde.org


  M +4 -4      knnntpclient.cpp   1.55


--- kdepim/knode/knnntpclient.cpp  #1.54:1.55
@@ -561,6 +561,6 @@ bool KNNntpClient::openConnection()
     return false;
     
-  if ((rep!=200)&&(rep!=201)) {  // 200 server ready - posting allowed
-    handleErrors();              // 201 server ready - no posting allowed
+  if ( ( rep < 200 ) || ( rep > 299 ) ) { // RFC977: 2xx - Command ok 
+    handleErrors();
     return false;
   }
@@ -576,6 +576,6 @@ bool KNNntpClient::openConnection()
 #endif
   } else
-    if ((rep!=200)&&(rep!=201)) { // 200 Hello, you can post
-      handleErrors();             // 201 Hello, you can't post
+    if ( ( rep < 200 ) || ( rep > 299 ) ) { // RFC977: 2xx - Command ok
+      handleErrors();
       return false;
     }