[Knode-devel] Re: [Kde-pim] [PATCH] Fix header colorization action of knode's scoring

[Ingo Klöcker]

On Wednesday 31 December 2003 12:12, Volker Krause wrote:
> On Wednesday 31 December 2003 00:46, Ingo Klöcker wrote:
> > Hmm, it would be better if you added a const to the method in the
> > parent class. After all this method should be const because it
> > doesn't change anything. And remember, BC is no issue. So changing
> > the interface of KScoring is no problem.
>
> Makes sense, new patch attached.

The changes in kscoring.h are okay.

> > It's always better to let Qt find a suitable id for a widget. This
> > id is returned by QWidgetStack::addWidget(...) and it should be
> > stored if it's needed later. Explicitely specifying an id will just
> > lead to problems (the id has to be unique because else Qt will
> > simply use another id -> same problem as now) and should be avoided
> > at all cost.
>
> Thats exactly what I'm trying to avoid, the problem seems the mixed
> usage of automatic and manual chosen id's. With the patch all id's
> are chosen manually and are therefore unique. If Qt would
> automatically chose numbers from 0 to n, that would be ok, but that
> was obviously not the case here. Then I would need to add some kind
> of 0..n to id mapping which seems quite unnecessary if I could chose
> useful id's myself.

Well, I had problems with manually assigned ids in the past and 
therefore had to use the automatically chosen ones. Anyway, with 
QWidgetStack using manually assigned ids is probably not that much 
trouble. So I'm fine with the patch if it works for you. But I'd prefer 
if you waited for Roberto's approval. After all, he's the maintainer of 
KNode.

Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: signature
Url : http://mail.kde.org/pipermail/knode-devel/attachments/20040101/e62988ef/attachment.pgp