[Knode-devel] Re: [Kde-pim] [PATCH] Fix header colorization action of knode's scoring

[Volker Krause]

On Wednesday 31 December 2003 00:46, Ingo Klöcker wrote:
> Hmm, it would be better if you added a const to the method in the parent
> class. After all this method should be const because it doesn't change
> anything. And remember, BC is no issue. So changing the interface of
> KScoring is no problem.

Makes sense, new patch attached.

> It's always better to let Qt find a suitable id for a widget. This id is
> returned by QWidgetStack::addWidget(...) and it should be stored if
> it's needed later. Explicitely specifying an id will just lead to
> problems (the id has to be unique because else Qt will simply use
> another id -> same problem as now) and should be avoided at all cost.

Thats exactly what I'm trying to avoid, the problem seems the mixed usage of 
automatic and manual chosen id's. With the patch all id's are chosen manually 
and are therefore unique. If Qt would automatically chose numbers from 0 to 
n, that would be ok, but that was obviously not the case here. Then I would 
need to add some kind of 0..n to id mapping which seems quite unnecessary if 
I could chose useful id's myself.

regards
Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kscoring_colorize.diff
Type: text/x-diff
Size: 1458 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/knode-devel/attachments/20031231/986ebb36/kscoring_colorize.bin