[Knode-devel] [PATCH] Fix header colorization action of knode's scoring

Volker Krause volker.krause at rwth-aachen.de
Tue Dec 30 18:30:57 CET 2003


Hi,

the attached patches for libkdenetwork and knode fixes the "Colorize Header" 
action of knode's scoring.

The knode patch reverts the last commit of knscoring.h which changed the 
signature of a virtual method (canColors()) by adding a const and thus the 
implementation of the parent class was used, which always returns false.

The libkdenetwork patch fixes the widget id's in the action widget stack in 
the scoring editor. For some reason the id of the label "Select an action:" 
is set to 3 here instead of 0, leading to a conflict with the color combobox 
and thus some weird results when you select an action. Setting it to 0 
explicitly fixes this.
Bug #62305 describes a similiar problem, but I'm not sure if it is really 
fixed by this (I couldn't reproduce it exactly).

Please let me know if I can commit.

regards
Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: knscoring_colorize.diff
Type: text/x-diff
Size: 543 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/knode-devel/attachments/20031230/c63b8a5b/knscoring_colorize.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kscoringeditor_widgetstackorder.diff
Type: text/x-diff
Size: 735 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/knode-devel/attachments/20031230/c63b8a5b/kscoringeditor_widgetstackorder.bin


More information about the Knode-devel mailing list