accept transaction cleared flag

[Scott Lair]

On Wed, 29 Jul 2020 12:43:17 -0400
Scott Lair <scott at laircpa.com> wrote:

> On Wed, 29 Jul 2020 16:33:27 +0200
> Thomas Baumgart <thb at net-bembel.de> wrote:
> 
> > Scott,
> > 
> > On Mittwoch, 29. Juli 2020 03:23:43 CEST Scott Lair wrote:
> >   
> > > I'm using 5.1.0 on debian linux.  I'd like to change the behavior
> > > of accepting imported transactions. Right now, the transaction is
> > > marked cleared. I would prefer the reconcile flag to remain empty.
> > > I was able to do this by changing the source code in version
> > > 4.8.0. The change was made around line 5830 in the kmymoney.cpp
> > > file. Simply commenting out one line did the trick.    
> > 
> > Oooh, that is a real hammer and makes the whole reconciliation stop
> > working ;)
> >   
> > > Can someone guide me as to where this can be changed in 5.1.0? I
> > > can't seem to figure out how it's implemented this time
> > > around.    
> > 
> > Check the following patch which should do what you want w/o breaking
> > the feature in general:
> > 
> > diff --git kmymoney/converter/mymoneystatementreader.cpp  
> > kmymoney/converter/mymoneystatementr> index 5de39e146..b710720e3  
> > 100644 --- kmymoney/converter/mymoneystatementreader.cpp
> > +++ kmymoney/converter/mymoneystatementreader.cpp
> > @@ -1130,7 +1130,7 @@ void
> > MyMoneyStatementReader::processTransactionEntry(const MyMoneyState>
> > if (statementTransactionUnderImport.m_listSplits.isEmpty()
> > && !payeeObj.defaultAccount> MyMoneyAccount splitAccount =
> > file->account(payeeObj.defaultAccountId()); MyMoneySplit s;
> > -        s.setReconcileFlag(eMyMoney::Split::State::Cleared);
> > +        // s.setReconcileFlag(eMyMoney::Split::State::Cleared);
> >          s.clearId();
> >          s.setBankID(QString());
> >          s.setShares(-s1.shares());
> > 
> > It removes the flag setting only during import.
> > 
> >   
> 
> Thank you sir,
> 
> I must have gotten a bad build. The setReconcileFlag line does not
> exist in my file. Downloaded the debian source on bullseye June, 15.
> 
> I just retrieved it again and the setReconcileFlag line is indeed
> there.
> 
> Back on track.
> 
> thanks much
> 
> Scott


OK, when I make the change, make and make install I get the same
behavior.

Import a file, accept a transaction and the reconcile flag is set to
cleared.

hmmm...   must be missing something.

Also tried the git download, but it fails on make. I haven't
looked into it.  Complaining about kmymoneysettings.h not found.

Scott