accept transaction cleared flag

[Thomas Baumgart]

On Mittwoch, 29. Juli 2020 19:07:58 CEST Jack wrote:

> On 2020.07.29 10:33, Thomas Baumgart wrote:
> > On Mittwoch, 29. Juli 2020 03:23:43 CEST Scott Lair wrote:
> > 
> > > I'm using 5.1.0 on debian linux.  I'd like to change the behavior  
> > of accepting imported transactions. Right now, the transaction is  
> > marked cleared. I would prefer the reconcile flag to remain empty. I  
> > was able to do this by changing the source code in version 4.8.0. The  
> > change was made around line 5830 in the kmymoney.cpp file. Simply  
> > commenting out one line did the trick.
> > Oooh, that is a real hammer and makes the whole reconciliation stop  
> > working ;)
> > 
> > > Can someone guide me as to where this can be changed in 5.1.0? I  
> > can't seem to figure out how it's implemented this time around.
> > Check the following patch which should do what you want w/o breaking  
> > the feature in general:
> > 
> > diff --git kmymoney/converter/mymoneystatementreader.cpp  
> > kmymoney/converter/mymoneystatementr>
> > index 5de39e146..b710720e3 100644
> > --- kmymoney/converter/mymoneystatementreader.cpp
> > +++ kmymoney/converter/mymoneystatementreader.cpp
> > @@ -1130,7 +1130,7 @@ void  
> > MyMoneyStatementReader::processTransactionEntry(const MyMoneyState>
> >        if (statementTransactionUnderImport.m_listSplits.isEmpty() &&  
> > !payeeObj.defaultAccount>
> >          MyMoneyAccount splitAccount =  
> > file->account(payeeObj.defaultAccountId());
> >          MyMoneySplit s;
> > -        s.setReconcileFlag(eMyMoney::Split::State::Cleared);
> > +        // s.setReconcileFlag(eMyMoney::Split::State::Cleared);
> >          s.clearId();
> >          s.setBankID(QString());
> >          s.setShares(-s1.shares());
> > 
> > It removes the flag setting only during import.
> 
> I'm a bit confused by this.  When I import transactions (OFX, file or  
> direct connect) transactions are not marked on import, but do get set  
> to cleared when I Accept them.  Am I missing something?

I think they also get set to cleared, when you have manually entered the
transaction (or have a schedule for it), KMyMoney imports the counterpart
and matches it.

If you import a transaction that you don't have on file (yet) it will set
the cleared flag when you accept it.

This information comes from memory not from reading source code :)

-- 

Regards

Thomas Baumgart

https://www.signal.org/       Signal, the better WhatsApp
-------------------------------------------------------------
To mess up a Linux box, you need to work at it;
to mess up your Windows box, you just need to work on it.
Scott Granneman, Security Focus
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 868 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kmymoney/attachments/20200801/cb366681/attachment.sig>