[kmymoney] [Bug 492837] New: Income and Expenses report needs some HTML improvements

[Glenn]

https://bugs.kde.org/show_bug.cgi?id=492837

            Bug ID: 492837
           Summary: Income and Expenses report needs some HTML
                    improvements
    Classification: Applications
           Product: kmymoney
           Version: 5.1.3
          Platform: Microsoft Windows
                OS: Microsoft Windows
            Status: REPORTED
          Severity: minor
          Priority: NOR
         Component: reports
          Assignee: kmymoney-devel at kde.org
          Reporter: gemdancer at fastem.com
  Target Milestone: ---

SUMMARY
The Income and Expenses -> Income and Expenses report has several HTML and CSS
issues.
This probably applies to many other reports also.

STEPS TO REPRODUCE
1.  Run the report Income and Expenses -> Income and Expenses 
2.  Export the report as HTML
3. Look at the generated HTML file with a text editor, and/or run it through a
HTML validator like https://validator.w3.org/nu/

OBSERVED RESULT
1. CSS has "background: "  items with a url which points to the kmymoney
installation folder.
That is useless if the file is moved to any place else, and probably even when
on this computer.
Delete the background items entirely.

2. Some of the HTML tags are missing a space between the parameters:
<tr class="row-odd"id="solo">  should be <tr class="row-odd" id="solo">

3. The HTML contains id="xxx" many times, with the same ID (see above,
id="solo").
An id is supposed to be unique in the page, just used once.
If you want to use the same item multiple times, it should be a class instead
of an id.

4. All HTML element values should be in quotes, but some are not:
<font color=#da4453>  should be  <font color="#da4453">
Better yet for this, set a class for the color and use the class instead of
specifying the color explicitly each time.

5. Vertical alignment of some table cells needs improvement in the CSS:
  td    { vertical-align: baseline }
It would be better to use "bottom" instead of "baseline".
It looks OK in a browser, but when I save the HTML page a PDF file, in the
Grand Total lines, the "Grand Total"  label does not line up with the values
(see attached PDF file).
Changing the vertical-align from "baseline" to "bottom" solves the problem.

4. There are no <a> links in the HTML, so don't need the A.xx items in the CSS.

3.  HTML DOCTYPE is specified as HTML 4.01 strict.
It would be nice to update the format for HTML 5.

EXPECTED RESULT
No "background:" CSS items with a url
Spaces between all HTML attributes.
Quotes around all HTML attribute values.
No duplicate "id" values.
Good table cell vertical alignment.
No A.xx items in the CSS

SOFTWARE/OS VERSIONS
Windows:  11

ADDITIONAL INFORMATION
KMyMoney 5.1.3-eefo4f1, installed via
kmymoney-5.1-3218-windows-cl-msvc2019-x86_64
You can check the format of the HTML using this page:
https://validator.w3.org/nu/

-- 
You are receiving this mail because:
You are the assignee for the bug.