[kmymoney] [Bug 489724] New: kmymoney depends on knewstuff library but is not used when cpp macro KMM_DEBUG is not defined

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=489724

            Bug ID: 489724
           Summary: kmymoney depends on knewstuff library but is not used
                    when cpp macro KMM_DEBUG is not defined
    Classification: Applications
           Product: kmymoney
           Version: git (master)
          Platform: Other
                OS: All
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: packaging
          Assignee: kmymoney-devel at kde.org
          Reporter: ralf.habacker at freenet.de
            Blocks: 488491
  Target Milestone: ---

STEPS TO REPRODUCE
1. see https://invent.kde.org/office/kmymoney/-/blob/master/CMakeLists.txt#L114
- knewstuff library is added
2. see
https://invent.kde.org/office/kmymoney/-/blame/master/kmymoney/kmymoney.cpp?page=5#L4002

OBSERVED RESULT
The knewstuff library is requested in the cmake build system unconditionally. 
An api function from knewstuff is used at
https://invent.kde.org/office/kmymoney/-/blame/master/kmymoney/kmymoney.cpp?page=5#L4002,
but the associate support is only reachable when the cpp macro KMM_DEBUG is
defined.

EXPECTED RESULT
If debugging is disabled, knewstuff should not be requested in the cmake build
system and not be used in the c++ code.

SOFTWARE/OS VERSIONS
Linux: openSUSE_Leap_15.5 
KDE Frameworks Version: 5.103.0
Qt Version:  5.15.4


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=488491
[Bug 488491] Make 5.2 release
-- 
You are receiving this mail because:
You are the assignee for the bug.