build error with a852b42098839919bc9e0dc5d7b7e4135fd4847d

[Jack]

I discovered there is no current maintainer for gwenhywfar in Gentoo,  
so 5.10.1 is the only available version.  I made my own ebuild for  
5.10.2, and that worked.  I suppose I will submit that, and then I'll  
try creating one for the latest beta, to be ready for the next release.


On 2024.12.03 05:37, Thomas Baumgart via KMyMoney-devel wrote:
> On Montag, 2. Dezember 2024 01:02:47 CET Jack Ostroff via  
> KMyMoney-devel wrote:
> 
> > Trying to compile latest master results in:
> >
> > In file included from
> >  
> /var/tmp/portage/app-office/kmymoney-9999-r1/work/kmymoney-9999/kmymoney/plugins/kbanking/gwenkdegui.cpp:11:
> > /usr/include/gwenhywfar5/gwen-gui-qt5/qt5dialogbox.hpp:23:95: error:
> > invalid conversion from 'int' to 'Qt::WindowType' [-fpermissive]
> >     23 |   QT5_DialogBox(QT5_GuiDialog *dialog, QWidget *parent=0,  
> bool
> > modal=false, Qt::WindowFlags f=0);
> 
> >  From the commit message "Activate deprecated warning again" I'm not
> > sure if I just need to wait for the fix in master mentioned in the
> > comment or if something else is missing, either in the code or in my
> > configuration.
> 
> You probably need to update your gwen version. Mine shows:
> 
>   QT5_DialogBox(QT5_GuiDialog *dialog, QWidget *parent=0, bool  
> modal=false, Qt::WindowFlags f={});
> 
> in line 23. The difference is
> 
>   "Qt::WindowFlags f=0"  vs.  "Qt::WindowFlags f={}"
> 
> 
> 
> This was changed over 2 years ago:
> 
> commit 7a85426581b6afd74cbe4f4c790fef5bc15c8ea0
> Author: Alexander Lohnau <alexander.lohnau at gmx.de>
> Date:   Sat Sep 3 09:45:40 2022 +0200
> 
>     Port deprecated QFlags constructor
> 
>     When consumers want to build without deprecated Qt public API  
> using for
>     example `-DQT_DISABLE_DEPRECATED_BEFORE=0x50f02` as a compile
>     definition, this line breaks the build. Adding this is currently  
> in the
>     works for KMyMoney.
> 
>     The fix is to just use the default constructor or an initializer  
> list
>     instead. Because the initializer list is available in Qt 5.4 and  
> the
>     default constructor in 5.15, the initializer list syntax is used.
>     See See https://doc.qt.io/qt-5/qflags-obsolete.html.
> 
>     Signed-off-by: Alexander Lohnau <alexander.lohnau at gmx.de>
>     Signed-off-by: Thomas Baumgart <thb at net-bembel.de>
> 
> 
> 
> 
> --
> 
> Regards
> 
> Thomas Baumgart
> 
> -------------------------------------------------------------
> Software and cathedrals are much the same –
> first we build them, then we pray. -- Sam Redwine, 1988
> -------------------------------------------------------------
>