New payees bug

[Thomas Baumgart]

On Montag, 24. Juli 2023 08:07:26 CEST Thomas Baumgart via KMyMoney-devel wrote:

> On Montag, 24. Juli 2023 01:08:03 CEST Jeremy Whiting wrote:
> 
> > I think the problem is that when you click Yes on that dialog to add the
> > payee it shouldn't reset the ledgerview at all. It doesn't when you click
> > No, it just clears the payee box. I think that makes sense, but when you
> > click Yes it shouldn't be doing anything to the ledger. Only adding the
> > payee as a payee behind the scenes and leaving the ledger completely alone.
> > So I can continue to add category, cleared status, etc. Thanks for the
> > pointer though, I'll see why it's calling LedgerView::reset in this case
> > when it shouldn't be IMO.
> 
> The reason is simple to explain: adding the payee to the MyMoneyFile object
> creates a MyMoneyFileTransaction. When that is created, the LedgerConcatenate
> model is instructed to stop emitting signals to prevent massive sorting
> operations when ledger objects change. When the MyMoneyFileTransaction
> object is destroyed, signal emission is turned on again and the
> LedgerConcatenate model is reset which is propagated to the LedgerView.

Fixed with https://invent.kde.org/office/kmymoney/-/commit/8f98eb55d84a388305da003881d6be8bcef6089e

-- 

Regards

Thomas Baumgart

-------------------------------------------------------------
When PRIVACY Is Outlawed...
Only OUTLAWS Will Have Privacy!
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 868 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20230729/346c9a06/attachment.sig>