some papercuts from master branch

[Jeremy Whiting]

https://invent.kde.org/office/kmymoney/-/merge_requests/185 fixes the date
looking focused but not really having focus until you hit tab.

For the other one it looks to me like the cause is the
KMyMoneyAccountCombo::eventFilter.

If the event is a tab key press, or a focus out it sets the line edit and
the view index, without sending changed signals (signal blockers in both
cases)
But if you hit enter key it does activated(); then hides the popup, which
does send out the changed signal. I'm not sure what the solution to that is
keeping existing functionality etc.

In the mean time I'll muscle memory hitting enter instead of just tab on
that field.

On Mon, Jan 2, 2023 at 9:15 PM Jeremy Whiting <jpwhiting at kde.org> wrote:

>
>
> On Mon, Jan 2, 2023 at 4:56 PM Jack <ostroffjh at users.sourceforge.net>
> wrote:
>
>> On 2023.01.02 18:31, Jeremy Whiting wrote:
>> > 2 other issues I keep hitting that I'm trying to find the cause of to
>> > fix:
>> >
>> > 1) Sometimes when I enter a category, it gets forgotten when I click
>> > the
>> > Enter button. It's not always, but when entering a new transaction,
>> > typing
>> > part of a Category, selecting it from the completion list, then tab
>> > until
>> > Enter is focused and hitting space/enter to click it. Or clicking the
>> > button. It seems to happen more often when the transaction is left Not
>> > reconciled. If it's cleared it usually remembers it.
>> I'm pretty sure this has been reported before.  When you select the
>> Category from the dropdown, pay attention to how you actually select
>> the value - clicking on it, hitting Enter, or Tabbing to the next
>> field.  I vaguely recall only one of those lost the selection.  I've
>> probably seen it myself, and just re-selected and moved on, instead of
>> tracking down the cause.
>>
>
> Yep, if I hit enter, then tab it keeps, it. If I just hit tab to move to
> the next field once it's the only remaining choice, it forgets. Ok digging
> in to see what's causing the difference. Thanks for pointing that out.
>
>>
>> > 2) Changing the date with the keyboard on a new transaction. Up arrow
>> > goes
>> > up to a previous transaction instead of increasing the date. typing
>> > numbers
>> > does nothing somehow. Only way I've found so far to change the date
>> > on a
>> > new transaction is to click it and select a date from the month view.
>> Are you sure you actually have the date field selected?  In my
>> experience, when you edit a transaction, no field is actually selected,
>> even though one part of the date field is highlighted.  It looks like
>> it is selected, but it isn't.  Hit Tab and now one part of the date
>> field is selected.
>>
>
> Yep, date just looks selected, but the hidden "Account" combo box is
> likely at first. Thanks, works much better once I tab into the date field
> itself. hmm.
>
>>
>> > I also noticed you have to hit tab twice to get from the date view to
>> > get
>> > to the payment box. Checking the .ui file it looks like an account
>> > combobox/edit box is first in the tab order, but that's hidden in
>> > ledger
>> > view.
>> >
>> > On Mon, Jan 2, 2023 at 3:48 PM Jack via KMyMoney-devel <
>> > kmymoney-devel at kde.org> wrote:
>> >
>> > > On 2022.12.28 09:25, Thomas Baumgart via KMyMoney-devel wrote:
>> > > > On Dienstag, 27. Dezember 2022 03:24:28 CET Jeremy Whiting via
>> > > > KMyMoney-devel wrote:
>> > > >
>> > > > > Hey all,
>> > > > >
>> > > > > I've switched back from 5.1.x to master branch for the past
>> > week or
>> > > > so and
>> > > > > hit a few papercuts. Not sure if there are existing plans for
>> > these
>> > > > yet or
>> > > > > not. If not I'll file bugs for each and try to tackle some as
>> > time
>> > > > permits.
>> > > > >
>> > > > > 1. Sorting: Cleared and reconciled transactions for a given day
>> > > > were not at
>> > > > > the top of that day's transactions.
>> > > > > https://invent.kde.org/office/kmymoney/-/merge_requests/182
>> > fixes
>> > > > that, but
>> > > > > leaves the running balance incorrect. I think that is still
>> > sorted
>> > > > by id or
>> > > > > something?
>> > > >
>> > > > Regarding the balance I am not sure what we do about it. More so,
>> > > > when sorting
>> > > > is based on a non-date column (e.g. detail or payee). Would
>> > sorting
>> > > > by balance
>> > > > make sense at all? Also, if there is a filter setup the balance is
>> > > > certainly
>> > > > not accurate anymore. What shall we do with it? Display "---" or
>> > > > simply nothing?
>> > > >
>> > > > Ideas and suggestions are welcome. We need to have a clear
>> > > > understanding on
>> > > > how we want this to behave before I make any more changes.
>> > >
>> > > I just ran into this issue with 5.1.80--ba8b90e64.  Sorting is
>> > default
>> > > (Post date, Reconcile state, Amount) but running balance is clearly
>> > > calculated in a different order. as the Balance and Cleared amount
>> > (the
>> > > same - there are no unmarked transactions) is on the transaction
>> > third
>> > > from the bottom.  As long as date is the first sort key, then I
>> > think
>> > > the running balance should be in the order displayed.  That was
>> > even if
>> > > the balances don't match a statement exactly for each transaction,
>> > they
>> > > should still match at the end of each day.
>> > >
>> > > Jack
>> > >
>> >
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20230102/a304e33d/attachment.htm>