appimage builds have been failing for over a week

[Thomas Baumgart]

On Freitag, 25. November 2022 23:16:32 CET Jack via KMyMoney-devel wrote:

> On 2022.11.25 06:22, Thomas Baumgart via KMyMoney-devel wrote:
> > On Freitag, 25. November 2022 02:45:05 CET Jack via KMyMoney-devel  
> > wrote:
> > 
> > > for 10/11 days, both master and stable have been failing on
> > > building/loading tcl.  Has this been reported or does it need to be
> > > reported to sysadmin?
> > 
> > This is what sysadmin answered 8 days ago upon my request:
> > 
> > ---8<---
> > bcooksley closed this task as "Resolved".
> > bcooksley claimed this task.
> > bcooksley added a comment.
> > 
> > 
> >   Shouldn't be anything I can think of, as the Docker images haven't  
> > been rebuilt in over a week so the only place that could have changed  
> > is Craft itself.
> > 
> >   I'd suggest:
> >   a) Reproducing locally using the kdeorg/centos7-craft image first
> >   b) Contacting the Craft devs (although i've given them a heads up  
> > of the issue already)
> > 
> >   Sysadmin only provides the infrastructure and tooling around this  
> > i'm afraid so not much we can do about issues in Craft...
> > 
> >   My guess would be something is running chmod() where it shouldn't  
> > be....
> > 
> > TASK DETAIL
> >   https://phabricator.kde.org/T15991
> > 
> > To: bcooksley
> > Cc: bcooksley, sysadmin, tbaumgart, sitter, duffus
> > ---8<---
> > 
> > I was counting on b) that the heads up would trigger some action.  
> > Apparently, that did not happen.
> > 
> > I have no knowledge about Craft and don't want to dive into it. So if  
> > anyone feels that he or she
> > needs adventure: here's one!
> 
> The few times I've dealt with Craft I've always gotten very lost.   
> However, on the #kde-craft IRC channel, I did get one suggestion:
> 
> <TheOneRing> Maybe something like  
> https://invent.kde.org/packaging/craft-blueprints-kde/-/blob/master/dev-utils/perl/perl.py#L81
> 
> and while it looks like a possible fix, I don't have any real idea  
> where to apply it.

Well, that's <TheOneRing>. She's often right at the spot but leaves you
in the dark without details because she may assume you're at the same
developer level as her. This is especially hard if it comes to Craft.

I share your statement that "The few times I've dealt with Craft I've
always gotten very lost."

Nevertheless, I gave it another try by scanning logs, Craft code and what not.

Findings:

The failing command

/opt/rh/devtoolset-9/root/usr/bin/strip --strip-debug --strip-unneeded /home/appimage/Craft/BinaryFactory/linux-64-gcc/build/libs/tcl/image-RelWithDebInfo-8-6-11/lib/libtcl8.6.so

is run many times before in this build, so it does not seem to be a general problem
with craft. I found the sequence in

  https://invent.kde.org/packaging/craft/-/blob/master/bin/utils.py#L1242

where strip tries to replace the file in place and that does not work due to
missing permissions. Looking at the build instructions for tcl I found

  https://github.com/tcltk/tcl/blob/main/unix/Makefile.in#L997

where the write permissions are removed (but for 11 years already) so
I wonder why it is failing now :(  But it matches Ben's guess about the
chmod run.

Then I found 

  https://invent.kde.org/packaging/craft/-/blob/master/bin/utils.py#L1242

which apparently resolves the issue for MacOS builds. This inspired me to add

  https://invent.kde.org/packaging/craft-blueprints-kde/-/commit/b787e7ba6fc7ba33cd9448e384cae1f777a526a1

with a few fixes afterwards and we're now back in business!

  https://binary-factory.kde.org/job/KMyMoney_Release_appimage-centos7/

p.s. Master will be build later.

-- 

Regards

Thomas Baumgart

-------------------------------------------------------------
Windows is not the answer. It's the question. The answer is no!
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 868 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20221126/5be7489a/attachment.sig>