[kmymoney] [Bug 419975] When importing CSV, we're matching against the other transactions also being imported

[Dawid Wróbel]

https://bugs.kde.org/show_bug.cgi?id=419975

--- Comment #1 from Dawid Wróbel <me at dawidwrobel.com> ---
Actually, after reading the code further I stand corrected - isImported() is a
member of MyMoneyTransaction, while CSV importer uses the
MyMoneyStatement::Transaction.

The MyMoneyStatementReader::processTransactionEntry() actually correctly sets
the transactionUnderImport.setImported(). The actual issue is with the
conditional expression I previously referred to – the !isImported() condition
should not be optional. Proposed resolution:

-      if (result == TransactionMatchFinder::MatchDuplicate
-      || !matchedTransaction.isImported()
-      || result == TransactionMatchFinder::MatchPrecise) { // don't match with
just imported transaction
+      if (!matchedTransaction.isImported() &&
+      (result == TransactionMatchFinder::MatchDuplicate || result ==
TransactionMatchFinder::MatchPrecise)) { // don't match with just imported
transaction

Let

-- 
You are receiving this mail because:
You are the assignee for the bug.