[kmymoney] [Bug 412366] New: Print to File (PDF) broken on KDE4 in 4.8.4

[Erich]

https://bugs.kde.org/show_bug.cgi?id=412366

            Bug ID: 412366
           Summary: Print to File (PDF) broken on KDE4 in 4.8.4
           Product: kmymoney
           Version: 4.8.4
          Platform: Slackware Packages
                OS: Linux
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: reports
          Assignee: kmymoney-devel at kde.org
          Reporter: erich.public+bugs.kde.org at protonmail.com
  Target Milestone: ---

Created attachment 122879
  --> https://bugs.kde.org/attachment.cgi?id=122879&action=edit
Restore "Print to File (PDF)" functionality for KDE4

SUMMARY
Commit 15ac7d472af41fc503dc5209643cfc8b392b0089, introduced in KMyMoney 4.8.4,
breaks Print to File (PDF) functionality on KDE4 in Slackware64 14.2. 
Reverting that commit on branch 4.8 HEAD restores Print to File (PDF)
functionality.

STEPS TO REPRODUCE
1. Choose Reports, 1. Income and Expenses -> Income and Expenses This Month
(Default Report)
2. Then choose Print, Print to File (PDF).

OBSERVED RESULT
KMyMoney goes through all the motions - including asking for confirmation to
overwrite an existing file - but the PDF does not get created.  Versions 4.8.3
and earlier create the PDF as expected.


EXPECTED RESULT
PDF file gets created by KMyMoney.

SOFTWARE/OS VERSIONS
Linux: Slackware64 14.2
KDE Platform Version: 4.14.38
Qt Version: 4.8.7

ADDITIONAL INFORMATION

I also developed a small patch which restores Print to File (PDF) functionality
for me, but the print dialog appears twice (I did expect that to happen when I
tried out the patch).  So it is not a proper patch.

What I believe is the cause of the problem:
The net result of patches:
5f4f90e83565647f3579660e4c5d9ac447547a02 Fix 'Printer settings are not saved'
15ac7d472af41fc503dc5209643cfc8b392b0089 Add print support for report charts
Changes the "print" command from
m_part->view()->print()
to
q->m_part->view()->print(true);
when KDE_IS_VERSION(4, 14, 65) is false (which is the case for me).

>From what I can tell from reading the docs (I am not a KDE developer), this
changes the "print" command from "print by asking the user how to print" to
"print using the default settings".  Unfortunately, those "default settings"
are not what KMyMoney asked about in the code immediately preceding the "print"
command, they must be the system-wide defaults.  My minimally-invasive patch
simply changes the print command back to what it used to be, with the net
effect that the print dialog appears twice when printing a report.

I did not test printing charts, which is what
15ac7d472af41fc503dc5209643cfc8b392b0089 addressed in the first place.

Another Slackware user was able to reproduce the issue.  See thread at:
https://lists.slackbuilds.org/pipermail/slackbuilds-users/2019-September/023367.html

-- 
You are receiving this mail because:
You are the assignee for the bug.