[kmymoney] [Bug 403068] Storing and loading customized information reports in XML is totally broken

[Thomas Baumgart]

https://bugs.kde.org/show_bug.cgi?id=403068

Thomas Baumgart <thb at net-bembel.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kmy
                   |                            |money/3939181ec1ce65de5c138
                   |                            |67e73e119cbcefca8b7
   Version Fixed In|                            |5.0.3
             Status|CONFIRMED                   |RESOLVED

--- Comment #5 from Thomas Baumgart <thb at net-bembel.de> ---
Git commit 3939181ec1ce65de5c13867e73e119cbcefca8b7 by Thomas Baumgart.
Committed on 13/01/2019 at 08:17.
Pushed by tbaumgart into branch '5.0'.

Fix customized report loading and saving

The storage of the accountgroup information for customized reports was
broken due to a mis-assignment between numeric and textual
representation. This was introduced with
https://phabricator.kde.org/D13581 which landed as commit
b7c44b7f705cd8.

With the current change, the account group information will be
reconstructed during loading of the file depending on the report type
and the above mentioned assignment problem will be fixed.

Also, the report type was not written for any customized information
report which caused a crash during usage after the next start of the
application. Since the report type cannot be detected automatically from
the available data in broken files, the type will be set to AccountInfo.

A respective message is dumped to the console. Users may have to
redesign their loan, schedule and schedule summary reports. The problem
shows, if a user opens such a report and it now displays an account
information report. Nevertheless, the original report filter settings
are loaded correctly.

All other report types are not affected by this problem.
FIXED-IN: 5.0.3

M  +1    -0    kmymoney/mymoney/mymoneyenums.h
M  +66   -49   kmymoney/mymoney/mymoneyreport.cpp
M  +22   -15   kmymoney/mymoney/mymoneyreport.h
M  +8    -2    kmymoney/plugins/views/reports/core/objectinfotable.cpp
M  +86   -80   kmymoney/plugins/xmlhelper/xmlstoragehelper.cpp

https://commits.kde.org/kmymoney/3939181ec1ce65de5c13867e73e119cbcefca8b7

-- 
You are receiving this mail because:
You are the assignee for the bug.