[kmymoney] [Bug 396831] 5.0 Version - Crashes when importing OFX/QFX File Using Firefox

[Thomas Baumgart]

Brendan,

On Montag, 26. November 2018 02:52:59 CET Brendan Coupe wrote:

> I compiled from the 5.0 branch and the problem is fixed. Thanks.

Thanks for the feedback.

> It's still present in the master branch. Will the fix be moved there
> soon? I was under the impression fixes were done in the master first
> and then moved to the branch that will be released eventually. I guess
> I'm still confused about the relationship between the branches.

Yes, it is not yet available on the master branch. I was waiting for positive feedback before I will merge it into master.

Regarding the branches: Whenever a x.0 release is created, a new stable branch is created for fixes. This branch will receive the bug-fixes an minor improvements which are merged to master from time to time. On master, we develop new features and functions. Merging the other way around, new features would land unwanted in the stable branch.

> Since this bug was difficult to track down I'm wondering if there are
> other bugs that are dependent on the view you have chosen to use.
> Since this is the second time the tabbed view has caused me a problem
> over the years I'll try to remember to test different views next time
> I run into a problem. I still prefer it to the other views.
> 
> It seems very strange to me that this is the cause of this bug. Is it
> obvious when you look at the code?

No, not at all. It was caused by the slightly different behavior of the KPageWidget object during destruction when configured in tabbed mode.

BTW, it was the instance that was started by the browser which crashed. Everything else should have worked since it crashed during exit processing after the filename had been transferred to the running instance with the data file open.

-- 

Regards

Thomas Baumgart

https://www.signal.org/       Signal, the better WhatsApp
-------------------------------------------------------------
Why are there so many 'smart phones'
used by so many 'stupid people'?
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 868 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20181126/e5092819/attachment.sig>