[kmymoney] [Bug 385993] Error in investment interest (Jahresrendite)

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=385993

Ralf Habacker <ralf.habacker at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/kmy |https://commits.kde.org/kmy
                   |money/4e3943cb7f183877a54ab |money/2910e97be0d2d1cfd13d7
                   |9b8182762fb502f93ff         |663c77baa19905f9eb3

--- Comment #11 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit 2910e97be0d2d1cfd13d7663c77baa19905f9eb3 by Ralf Habacker.
Committed on 15/11/2018 at 22:41.
Pushed by habacker into branch '5.0'.

Corrections for XIRR implementation to achieve more accurate values

Summary:
In the Investment Report, the XIRR() function is used to calculate
the annual return. The previous implementation contains some errors
that have been corrected with this commit. In addition, if XIRR
cannot calculate the annual return to notify the user of this case,
an empty column is displayed in the investment report.

The basis for this fix is an update of the XIRR implementation from
the KOffice project [1], which brings the calculation up to date and
a further improvement from the libreoffice XIRR implementation [2] to
get more solutions using a two-pass approach. The class CashFlowList
has been moved to separate files to have a cleaner separation.

The obsolete and unused NPV function has been removed.

Tests for XIRR have been extended to check for recognized issues.

[1] https://github.com/KDE/koffice/blob/master/kcells/functions/financial.cpp
[2]
https://raw.githubusercontent.com/LibreOffice/core/master/scaddins/source/analysis/financial.cxx
FIXED-IN:4.8.3, 5.0.3

Test Plan: compiled and tested on linux

Reviewers: tbaumgart, wojnilowicz

Differential Revision: https://phabricator.kde.org/D16766

M  +1    -0    kmymoney/plugins/views/reports/core/CMakeLists.txt
A  +166  -0    kmymoney/plugins/views/reports/core/cashflowlist.cpp    
[License: GPL (v2+)]
A  +75   -0    kmymoney/plugins/views/reports/core/cashflowlist.h     [License:
GPL (v2+)]
M  +10   -205  kmymoney/plugins/views/reports/core/querytable.cpp
M  +2    -91   kmymoney/plugins/views/reports/core/querytable.h
M  +47   -6    kmymoney/plugins/views/reports/core/tests/querytable-test.cpp

https://commits.kde.org/kmymoney/2910e97be0d2d1cfd13d7663c77baa19905f9eb3

-- 
You are receiving this mail because:
You are the assignee for the bug.