[kmymoney] [Bug 391091] Year is not shown in plots

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=391091

--- Comment #9 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit 2f575bbe69214798c67b8b47e0c2f6baa67584a4 by Ralf Habacker.
Committed on 07/03/2018 at 09:46.
Pushed by habacker into branch '4.8'.

Convert enumeration MyMoneyReport::EReportType into a class to be more type
safe

Test Plan: compiled on linux

Reviewers: #kmymoney

Reviewed By: #kmymoney, tbaumgart

Differential Revision: https://phabricator.kde.org/D11058

Signed-off-by: Ralf Habacker <ralf.habacker at freenet.de>

M  +2    -2    kmymoney/dialogs/kreportconfigurationfilterdlg.cpp
M  +28   -28   kmymoney/mymoney/mymoneyreport.cpp
M  +15   -12   kmymoney/mymoney/mymoneyreport.h
M  +3    -3    kmymoney/views/kreportsview.cpp

https://commits.kde.org/kmymoney/2f575bbe69214798c67b8b47e0c2f6baa67584a4

--- Comment #8 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit ad66b57f7397b15e7e8d1667101fdaf23b8601d0 by Ralf Habacker.
Committed on 07/03/2018 at 09:46.
Pushed by habacker into branch '4.8'.

Convert enumeration MyMoneyReport::EQueryColumns into a class to be more type
safe

Test Plan: compiled on linux

Reviewers: #kmymoney

Reviewed By: #kmymoney, tbaumgart

Differential Revision: https://phabricator.kde.org/D11053

M  +26   -26   kmymoney/dialogs/kreportconfigurationfilterdlg.cpp
M  +1    -1    kmymoney/kmymoney.cpp
M  +11   -12   kmymoney/mymoney/mymoneyreport.cpp
M  +10   -7    kmymoney/mymoney/mymoneyreport.h
M  +15   -15   kmymoney/reports/querytable.cpp
M  +20   -20   kmymoney/reports/querytabletest.cpp
M  +20   -20   kmymoney/views/kreportsview.cpp

https://commits.kde.org/kmymoney/ad66b57f7397b15e7e8d1667101fdaf23b8601d0

--- Comment #7 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit 1e5384157ca6f33c49ebd3bed1fed7967a7edbd9 by Ralf Habacker.
Committed on 07/03/2018 at 09:46.
Pushed by habacker into branch '4.8'.

Convert enumeration MyMoneyReport::EColumnType into a class to be more type
safe

Type safety is increased by moving the enum into a separate name space (here
a class is used because namespaces are not allowed inside classes).

Q_ENUM(s) or QFlags could also not be used because the related enums need
to be defined somewhere outside, which does not solve the issue having all
constants in MyMoneyReport namespace.

Test Plan: compiled on linux

Reviewers: #kmymoney

Reviewed By: #kmymoney, tbaumgart

Differential Revision: https://phabricator.kde.org/D11043

Signed-off-by: Ralf Habacker <ralf.habacker at freenet.de>

M  +1    -1    kmymoney/dialogs/kbalancechartdlg.cpp
M  +10   -10   kmymoney/dialogs/kreportconfigurationfilterdlg.cpp
M  +8    -7    kmymoney/mymoney/mymoneyreport.cpp
M  +8    -5    kmymoney/mymoney/mymoneyreport.h
M  +14   -14   kmymoney/reports/pivottable.cpp
M  +10   -10   kmymoney/reports/pivottabletest.cpp
M  +1    -1    kmymoney/views/kforecastview.cpp
M  +2    -2    kmymoney/views/khomeview.cpp
M  +31   -31   kmymoney/views/kreportsview.cpp

https://commits.kde.org/kmymoney/1e5384157ca6f33c49ebd3bed1fed7967a7edbd9

--- Comment #6 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit 0179eea65d078fe273ab79cbf96bf32698302ac1 by Ralf Habacker.
Committed on 07/03/2018 at 09:51.
Pushed by habacker into branch '4.8'.

Convert enumeration MyMoneyReport::ERowType into a class to be more type safe

Summary:

Test Plan: compiled on linux

Reviewers: #kmymoney

Reviewed By: #kmymoney, tbaumgart

Differential Revision: https://phabricator.kde.org/D11083

M  +1    -1    kmymoney/dialogs/kbalancechartdlg.cpp
M  +19   -19   kmymoney/dialogs/kreportconfigurationfilterdlg.cpp
M  +1    -1    kmymoney/kmymoney.cpp
M  +50   -52   kmymoney/mymoney/mymoneyreport.cpp
M  +18   -15   kmymoney/mymoney/mymoneyreport.h
M  +1    -1    kmymoney/reports/listtable.cpp
M  +9    -9    kmymoney/reports/objectinfotable.cpp
M  +4    -4    kmymoney/reports/pivottable.cpp
M  +38   -38   kmymoney/reports/pivottabletest.cpp
M  +38   -38   kmymoney/reports/querytable.cpp
M  +14   -14   kmymoney/reports/querytabletest.cpp
M  +1    -1    kmymoney/views/kforecastview.cpp
M  +2    -2    kmymoney/views/khomeview.cpp
M  +51   -51   kmymoney/views/kreportsview.cpp

https://commits.kde.org/kmymoney/0179eea65d078fe273ab79cbf96bf32698302ac1

-- 
You are receiving this mail because:
You are the assignee for the bug.