[kmymoney] [Bug 396759] CSV: ordering of buttons when finishing wizard

Thomas Baumgart bugzilla_noreply at kde.org
Sun Jul 29 17:58:05 BST 2018


https://bugs.kde.org/show_bug.cgi?id=396759

Thomas Baumgart <thb at net-bembel.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kmy
                   |                            |money/033b747aa5184b29dd846
                   |                            |d1573ce87a0cd6bffab

--- Comment #1 from Thomas Baumgart <thb at net-bembel.de> ---
Git commit 033b747aa5184b29dd846d1573ce87a0cd6bffab by Thomas Baumgart.
Committed on 29/07/2018 at 16:58.
Pushed by tbaumgart into branch 'master'.

Improve CSV importer

Summary:
- Make the CSV importer to run as a modal dialog of the application as
other importers do. This avoids a whole bunch of problems.

- Combine the Finish and Import button into a single "Import CSV" button
on the last page of the wizard.

- In case 'Skip setup' is marked on the first page, the wizard stops on
the last page and does not automatically start importing.

Test Plan: Tested single file import and web-connect import

Reviewers: wojnilowicz

Reviewed By: wojnilowicz

Differential Revision: https://phabricator.kde.org/D14459

M  +1    -1    kmymoney/kmymoney.cpp
M  +18   -34   kmymoney/plugins/csv/import/csvimporter.cpp
M  +1    -11   kmymoney/plugins/csv/import/csvimporter.h
M  +37   -37   kmymoney/plugins/csv/import/csvwizard.cpp
M  +6    -7    kmymoney/plugins/csv/import/csvwizard.h

https://commits.kde.org/kmymoney/033b747aa5184b29dd846d1573ce87a0cd6bffab

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the KMyMoney-devel mailing list