[kmymoney] [Bug 396405] Last digit of date field is obscured by "details column" in ledger view

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=396405

--- Comment #4 from Ralf Habacker <ralf.habacker at freenet.de> ---
(In reply to Thomas Baumgart from comment #3)
> I am not sure where the LongDate comes into play.

In KDE regional settings you have two fields

Long date format: e.g. which may be "WEEKDAY DD MONTH YYYY"

and Short date format: eg. "YYYY-MM-DD"

There is nothing which prevents entering "WEEKDAY DD MONTH YYYY" or "WEEKDAY
YYYY-MM-DD" into the short date format field, which is then displayed in the
date column of the ledger view. 

> But we only use ShortDate here which should have a fixed size of 10 chars. 
> Using 6999-12-29 should provide the greatest width with proportional fonts.

which works only for the "YYYY-MM-DD" date format. For any other format string
the calculation using the fixed date may not return the longest date string
depending on the current language and may hide digits from the date.

An example: If the user chooses date format "WEEKDAY DD MONTH YYYY", in german
the date for the longest date string  "Donnerstag, 26 September 6999" is
6999-09-26, while in english one of the longest string "Wednesday, 25 September
6999" is 6999-09-25. This may differ for other language. 

>From what I can see now, a correct implementation of
Register::minimumColumnWidth() should get the longest date string for the
current language by iterating all dates for a whole given year once at
application start and use that for the date column minimal width.

>The change you made only adjusts the height not the width. 
This is funny: removing the two rows has already adjusted the width of the date
column to the contained date but had no influence on the height.

-- 
You are receiving this mail because:
You are the assignee for the bug.