[kmymoney] [Bug 389631] Date edit should default on day section

Ralf Habacker bugzilla_noreply at kde.org
Tue Feb 6 20:07:56 UTC 2018


https://bugs.kde.org/show_bug.cgi?id=389631

Ralf Habacker <ralf.habacker at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.8.2
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kmy
                   |                            |money/904775b2005c888abaf86
                   |                            |9b70ab8c46f0e1e5074
         Resolution|---                         |FIXED

--- Comment #7 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit e0e1604642ac5245d232349f7a5cf203652075af by Ralf Habacker.
Committed on 06/02/2018 at 20:05.
Pushed by habacker into branch '4.8'.

Fix issues with multiple instances of KMyMoneySettings

Calling a static method from class KMyMoneyGlobalSettings inside
kmm_widgets library surprisingly creates an additional KMymoneySettings
instance, which does not reflect the recent state from the setting dialog.
The reason for this behavior is caused by duplicated implementations of
class KMymoneySettings (kmm_config, settings) and embedding the static
library kmm_config into shared libraries (kmm_mymoney, kmm_widgets and
kmm_ofximport). Each embedded copy has it's own instance of class
KMymoneySettings.

The solution for this issue, which is done with this patch, is to remove
the duplicated implementation from the settings library and to make
kmm_config a shared library.

This patch also renames kmm_config to kmm_settings and place it into it
own subdirectory to keep in sync with 5.0 branch.
Related: bug 374123
FIXED-IN:4.8.2

Test Plan: compiled on linux

Reviewers: #kmymoney, tbaumgart

Reviewed By: tbaumgart

Subscribers: tbaumgart

Differential Revision: https://phabricator.kde.org/D10322

M  +10   -10   kmymoney/CMakeLists.txt
M  +1    -1    kmymoney/converter/CMakeLists.txt
M  +1    -8    kmymoney/dialogs/settings/CMakeLists.txt
M  +1    -1    kmymoney/models/CMakeLists.txt
M  +1    -1    kmymoney/mymoney/CMakeLists.txt
M  +1    -1    kmymoney/plugins/onlinetasks/sepa/CMakeLists.txt
M  +5    -5    kmymoney/reports/CMakeLists.txt
A  +13   -0    kmymoney/settings/CMakeLists.txt
R  +0    -0    kmymoney/settings/kmymoney.kcfg [from: kmymoney/kmymoney.kcfg -
100% similarity]
R  +2    -0    kmymoney/settings/kmymoneysettings.kcfgc [from:
kmymoney/kmymoneysettings.kcfgc - 053% similarity]
M  +4    -4    kmymoney/widgets/CMakeLists.txt

https://commits.kde.org/kmymoney/e0e1604642ac5245d232349f7a5cf203652075af

--- Comment #6 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit 904775b2005c888abaf869b70ab8c46f0e1e5074 by Ralf Habacker.
Committed on 06/02/2018 at 20:06.
Pushed by habacker into branch '4.8'.

Allow the user to select the initial date cursor position in the settings
dialog

As default the cursor position is set to the day part of the date field.

This patch contains a fix to be compilable with gcc 4.8.
Related: bug 374123
FIXED-IN:4.8.2

Test Plan: compiled and tested on linux

Reviewers: #kmymoney, tbaumgart

Reviewed By: #kmymoney, tbaumgart

Subscribers: tbaumgart

Differential Revision: https://phabricator.kde.org/D10310

M  +46   -0    kmymoney/dialogs/settings/ksettingsregisterdecl.ui
M  +9    -0    kmymoney/settings/kmymoney.kcfg
M  +1    -0    kmymoney/settings/kmymoneysettings.kcfgc
M  +12   -4    kmymoney/widgets/kmymoneydateinput.cpp

https://commits.kde.org/kmymoney/904775b2005c888abaf869b70ab8c46f0e1e5074

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the KMyMoney-devel mailing list