Review Request 130241: Add system wide checkbox 'Do not show this again' for duplicated check number request dialog

Thomas Baumgart tbaumgart at kde.org
Wed Sep 6 08:52:10 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130241/#review103688
-----------------------------------------------------------



Otherwise it looks good to me.


kmymoney/dialogs/transactioneditor.cpp (line 284)
<https://git.reviewboard.kde.org/r/130241/#comment68990>

    use QLatin1String("DuplicateNumber") on the right side of this assignment.



kmymoney/dialogs/transactioneditor.cpp (line 287)
<https://git.reviewboard.kde.org/r/130241/#comment68991>

    Change the two QString("<qt>") into QLatin1String("<qt>") here.


- Thomas Baumgart


On Sept. 6, 2017, 10:35 vorm., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130241/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 10:35 vorm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 360500
>     http://bugs.kde.org/show_bug.cgi?id=360500
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Add a checkbox "do not show again" to duplicated check number request dialog
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/transactioneditor.cpp b1a3d00f7b57b29330b860f0b3762ee4e4294028 
> 
> Diff: https://git.reviewboard.kde.org/r/130241/diff/
> 
> 
> Testing
> -------
> 
> compiled with 4.8 branch
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170906/90cd9f9b/attachment.html>


More information about the KMyMoney-devel mailing list