Review Request 130236: Make Qt4 build support working again by specifing -DBUILD_QT4=1 on cmake configure line

Ralf Habacker ralf.habacker at freenet.de
Fri Sep 1 09:19:03 UTC 2017 


> On Aug. 29, 2017, 5:27 nachm., Jack Ostroff wrote:
> > Please clarify - this makes the qt4 and qt5 versions of libalkimia co-installable.  Is that only if both are the same version, or is it also true if you compile libalkimia 5.0.0 (released) with qt4 and 6.0.0 (from git) with qt5?  KMyMoney 4.8 requires <6.0 and KMyMoney 5.0 (git head) requires >=6.0.  The latest change goes to 7.0.0 (was there ever a 6.0.0?) which cannot be used by KMM 4.8.x although it is still mentioned.
> 
> Ralf Habacker wrote:
>     > Is that only if both are the same version,
>     yes version 7.0.0 unified qt4 and qt5 builds to one source.
>     
>     > or is it also true if you compile libalkimia 5.0.0 (released) with qt4 and 6.0.0 (from git) with qt5? 
>     no, libalkimia 5.0 (qt4 only) and 6.0 (qt5 only) uses the same include header path and library names
>     
>     >KMyMoney 4.8 requires <6.0 and KMyMoney 5.0 (git head) requires >=6.0.
>     Is this only because of alkimia build system issues or are there any code changes involved ? In case of the first, the are no problems with this patch. 
>     
>     >The latest change goes to 7.0.0 
>     
>     >(was there ever a 6.0.0?)
>     git tag shows 5.0.0 as the last one, so no 
>     
>     CMakeLists specifies 6.0.90 as current version, the next stable version would be 6.1.0 - is that acceptable ? Or simply using  6.0.0 as public release ?
> 
> Jack Ostroff wrote:
>     I think I see what I was missing.  
>     
>     Version 5.0.0 was qt4 only, version 6.0.90 was qt5 only, and now you are allowing both qt versions for a single alkimia version.  (Correct me if I'm still not right.)
>     
>     I have no objection to that, although I don't think there will be much future use for qt4.  However, out of curiosity, if qt5 was the only reason KMM 4.8 would not work with alkimia 6, then would KMM 4.8 work with the qt4 version of alikimia 7?  
>     
>     I'm OK with jumping to 7 because of this switch, although 6.1 would also be OK.  I would probably skip 6.0.0 just to avoid decreasing the version number, even if nobody used it when pulling a git version.

> and now you are allowing both qt versions for a single alkimia version.
yes

> although I don't think there will be much future use for qt4
this depends on the release time of a stable Windows port of kmymoney/KF5. Until this point a qt4 based version of alkimia is required and a unified version makes support easier

>would KMM 4.8 work with the qt4 version of alikimia 7? 
yes

>I'm OK with jumping to 7 because of this switch, although 6.1 would also be OK. 
Using 7.0 make it more save in relation to released binary packages, so 7.0 is the choice :-)
Because the patch already specifies 7.0.0 I think it is ready for submitting, please finish review.


- Ralf


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130236/#review103658
-----------------------------------------------------------


On Aug. 29, 2017, 4:06 nachm., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130236/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2017, 4:06 nachm.)
> 
> 
> Review request for KMymoney and Skrooge.
> 
> 
> Repository: alkimia
> 
> 
> Description
> -------
> 
> The installed package is coinstallable with the Qt5 variant.
> See README.md for more details how to use.
> 
> Required for building stable kmymoney releases, which are Qt4 based.
> 
> REVIEW:130236
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 19f3e4d367324841e12b426ae9cadc127aa0e597 
>   README.md PRE-CREATION 
>   autotests/CMakeLists.txt faa9973d750503cb5ef017c70a0b4a29181ab5dd 
>   src/CMakeLists.txt 9765cf7c43e5c09fe20c7a6ac1b872718eeac781 
>   src/LibAlkimiaConfig.cmake.in cce2f7c420109d981f21866b0ed57bdf7ae834f8 
>   src/libalkimia.pc.in 871e3f30ac0ead437b84707506d3b8d770d9f007 
> 
> Diff: https://git.reviewboard.kde.org/r/130236/diff/
> 
> 
> Testing
> -------
> 
> - compiled for qt4 and qt5
> - used to build with kmymoney4 and kmymoney/KF5
> - installation gives install tree for qt4: 
> tmp/usr/local/include/alkimia/Qt4/alkimia/alkcompany.h
> tmp/usr/local/include/alkimia/Qt4/alkimia/alkvalue.h
> tmp/usr/local/include/alkimia/Qt4/alkimia/alk_export.h
> tmp/usr/local/include/alkimia/Qt4/alkimia/alkquoteitem.h
> tmp/usr/local/lib64/libalkimia.so
> tmp/usr/local/lib64/libalkimia.so.7
> tmp/usr/local/lib64/libalkimia.so.7.0.90
> tmp/usr/local/lib64/pkgconfig/libalkimia.pc
> tmp/usr/local/lib64/cmake/LibAlkimia-7.0
> tmp/usr/local/lib64/cmake/LibAlkimia-7.0/LibAlkimiaConfig.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia-7.0/LibAlkimiaTargets-noconfig.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia-7.0/LibAlkimiaConfigVersion.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia-7.0/LibAlkimiaTargets.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia-7.0/FindGMP.cmake
> 
> - file content of libalkimia.pc
> 
> # pkg-config configuration for libalkimia
> # For information about the syntax, see pkg-config(1)
> 
> # General installation directories
> prefix=/usr/local
> exec_prefix=/usr/local
> libdir=
> includedir=include/alkimia/Qt4
> 
> # Human-readable name
> Name: Alkimia
> # Human-readable description
> Description: A library for financial data handling
> Version: 7.0.90
> 
> Libs: -lalkimia
> Libs.private: -lgmp -lQtCore -lQtDBus -lstdc++
> Cflags: -I${includedir}
> 
> 
> - installation gives install tree for qt5: 
> tmp/usr/local/include/alkimia/Qt5/alkimia/alkcompany.h
> tmp/usr/local/include/alkimia/Qt5/alkimia/alkvalue.h
> tmp/usr/local/include/alkimia/Qt5/alkimia/alk_export.h
> tmp/usr/local/include/alkimia/Qt5/alkimia/alkquoteitem.h
> tmp/usr/local/lib64/libalkimia5.so
> tmp/usr/local/lib64/libalkimia5.so.7
> tmp/usr/local/lib64/libalkimia5.so.7.0.90
> tmp/usr/local/lib64/pkgconfig/libalkimia5.pc
> tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/LibAlkimia5Config.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/LibAlkimia5Targets.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/LibAlkimia5ConfigVersion.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/LibAlkimia5Targets-noconfig.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/FindGMP.cmake
> 
> - file content of libalkimia5.pc
> 
> # pkg-config configuration for libalkimia
> # For information about the syntax, see pkg-config(1)
> 
> # General installation directories
> prefix=/usr/local
> exec_prefix=/usr/local
> libdir=
> includedir=include/alkimia/Qt5
> 
> # Human-readable name
> Name: Alkimia
> # Human-readable description
> Description: A library for financial data handling
> Version: 7.0.90
> 
> Libs: -lalkimia5
> Libs.private: -lgmp -lQt5Core -lQt5DBus -lstdc++
> Cflags: -I${includedir}
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170901/7fe76be9/attachment-0001.html>

More information about the KMyMoney-devel mailing list