StorageSQL Version conflict

[Thomas Baumgart]

Hi all,

On Sonntag, 1. Oktober 2017 22:54:51 CEST Ralf Habacker wrote:

> Hi all,
> 
> currently I inspected the differences between 4.8 and master and got the
> impression that  git master uses a version already allocated by 4.8.
> 
> With commithttps://commits.kde.org/kmymoney/
> <https://commits.kde.org/kmymoney/75efcd673f8a750681ba35cc6e12a4d6d13ca474>6
> bce2ac059f1921ead3362687e48ce84367238d2 sql storage  version has been raised
> to V11 which is implemented as
> 
> int MyMoneyStorageSql::upgradeToV11()
> 
> {
>   DBG("*** Entering MyMoneyStorageSql::upgradeToV11");
>   MyMoneyDbTransaction dbtrans(*this, Q_FUNC_INFO);
> 
>   QSqlQuery q(*this);
>   if (!alterTable(m_db.m_tables["kmmSchedules"], m_dbVersion))
>     return 1;
>   return 0;
> }
> 
> in master commit https://commits.kde.org/kmymoney/
> <https://commits.kde.org/kmymoney/75efcd673f8a750681ba35cc6e12a4d6d13ca474>f
> d6a9557c637875aff7e53415f7c042c8f636858 reuses this version.
> 
> int MyMoneyStorageSql::upgradeToV11()
> {
>   MyMoneyDbTransaction dbtrans(*this, Q_FUNC_INFO);
> 
>   QSqlQuery q(*this);
>   // add column roundingMethodCol to kmmSecurities
>   if (!alterTable(m_db.m_tables["kmmSecurities"], m_dbVersion))
>     return (1);
>   // add column pricePrecision to kmmCurrencies
>   if (!alterTable(m_db.m_tables["kmmCurrencies"], m_dbVersion))
>     return (1);
> 
>   return 0;
> }

This fact is true, unfortunately. One reason, we decided long time ago that 
4.8 does not receive new features, but this remained unheard.


> To solve the issue, 4.8 branch should be merged into master to be in
> sync or the related commit from 4.8 branch should be applied to master
> too and master should then update to sql storage version 12.

It's not that easy, because if I open a V11 database today, I don't know which 
V11 it is and what needs to be done.

So far, I don't have an idea to get out of this mess. Anyone else?

-- 

Regards

Thomas Baumgart

https://www.telegram.org/       Telegram, the better WhatsApp
-------------------------------------------------------------
What is mind? No matter. What is matter? Never mind.
 (Punch, 1855)
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 846 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20171002/2efe2dad/attachment.sig>