Review Request 130135: Removed national credit transfers

[Christian David (c.david)]

Hello Andreas,

I noticed that build.kde.org fails since this review request was checked in 
[1]. Do you know why? Or can you even fix it (I cannot compile the 4.8 branch)? 
If not, we can just revert the commit. This change cleans our codebase but 
does not change anything for the user (and the branch 4.8 is at end of 
lifetime).

Best,
Christian


[1] https://build.kde.org/job/kmymoney%204.8%20latest-qt4/89/

On Dienstag, 23. Mai 2017 20:16:21 CEST Andreas Sturmlechner wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130135/
> -----------------------------------------------------------
> 
> (Updated May 23, 2017, 6:16 p.m.)
> 
> 
> Status
> ------
> 
> This change has been marked as submitted.
> 
> 
> Review request for KMymoney.
> 
> 
> Changes
> -------
> 
> Submitted with commit c78183f18201b16436008ea4306a974f180141d7 by Andreas
> Sturmlechner on behalf of Christian Dávid to branch 4.8.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> They are not supported by the banks anymore. So they can be removed.
> 
> Unfortunately they contained the only example for a task converter.
> Due to the removed plugin the CMakeLists.txt for sepa could be
> simplified.
> 
> Cherry-picked from d514e650
> 
> 
> Diffs
> -----
> 
>   kmymoney/plugins/kbanking/aqbankingkmmoperators.h
> a314cd7218118cd695ade0d2344fbb450c698b16
> kmymoney/plugins/kbanking/aqbankingkmmoperators.cpp
> 6c2b5d8a9963c0506c52d2e105fa2443f8350a52
> kmymoney/plugins/kbanking/mymoneybanking.h
> c2559ae73aa5aeaaaa5c5480ffac8512d6936a94
> kmymoney/plugins/kbanking/mymoneybanking.cpp
> d8c4a5711548ef5b0f29e228100b35d2d675f238
> kmymoney/plugins/kbanking/tasksettings/credittransfersettingsbase.h
> 28d55a06f1e4446bd1840e8be368533824b6e5d1
> kmymoney/plugins/onlinetasks/CMakeLists.txt
> 7be531376bdf24bd415a9af32812b3a7c47a07b6
> kmymoney/plugins/onlinetasks/national/CMakeLists.txt
> d3e7c44f937d001fed67dcb4b58ba14f293ea774
> kmymoney/plugins/onlinetasks/national/converter/CMakeLists.txt
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> kmymoney/plugins/onlinetasks/national/converter/taskconvertergermantosepa.h
> 7653c231fd4d142956a39ac47307f43998cc1344
> kmymoney/plugins/onlinetasks/national/converter/taskconvertergermantosepa.c
> pp d10b3933271235186fe81cceea0cdb2cd1b30d02
> kmymoney/plugins/onlinetasks/national/converter/taskconvertersepatogerman.h
> 900f8d8025ba88f3c2d8fe90bcb9b873dc2897c5
> kmymoney/plugins/onlinetasks/national/converter/taskconvertersepatogerman.c
> pp a7aae64d153a6af9f21586f97fca27865df76b77
> kmymoney/plugins/onlinetasks/national/kmymoney-nationalorders.desktop.in
> af817eed71f4f3aa6f444d3064b2b612824660f1
> kmymoney/plugins/onlinetasks/national/kmymoney-nationalordersui.desktop.in
> f548a33df084cd08d39cdc99356025fbf7052f3b
> kmymoney/plugins/onlinetasks/national/kmymoney-nationalstorageplugin.deskto
> p.in 86db1b08b116ecdab174025faef107a52ae93239
> kmymoney/plugins/onlinetasks/national/nationalonlinetasksloader.h
> 44157e412b27b0f759d2607ebea65d663eced0da
> kmymoney/plugins/onlinetasks/national/nationalonlinetasksloader.cpp
> 4a0c9e7586646c162021e66e5146912fc335c151
> kmymoney/plugins/onlinetasks/national/nationalstorageplugin.h
> c61054b3e892838318e60302ed90ca37c5345eac
> kmymoney/plugins/onlinetasks/national/nationalstorageplugin.cpp
> 5464fb94495b4ecbf0d73a498e9b4badccc6aa94
> kmymoney/plugins/onlinetasks/national/tasks/germanonlinetransfer.h
> 660b4aa481696b58245e3b638a7827e7cb4d23b0
> kmymoney/plugins/onlinetasks/national/tasks/germanonlinetransferimpl.h
> 0b9745574ecdfd17a168ccad5543a8883e92225e
> kmymoney/plugins/onlinetasks/national/tasks/germanonlinetransferimpl.cpp
> a7b4421f2ea0403f4aaf187d39e3c22ae5b19e93
> kmymoney/plugins/onlinetasks/national/tests/CMakeLists.txt
> e606d2d2cbec0c4cc1418f6b23aab20392606da8
> kmymoney/plugins/onlinetasks/national/tests/germanonlinetransfertest.h
> 9c2ca335b7454ec745fa70b56e0b4e3780f0740a
> kmymoney/plugins/onlinetasks/national/tests/germanonlinetransfertest.cpp
> 63834e7952b15fc4f43b0dac40a7d612ea5b97c0
> kmymoney/plugins/onlinetasks/national/ui/germancredittransferedit.h
> aa07cdaa7fcb315cddd6b0ec91090c039d661570
> kmymoney/plugins/onlinetasks/national/ui/germancredittransferedit.cpp
> 8e0da0815e6938cd8b7086e2d955e6de0d452fd9
> kmymoney/plugins/onlinetasks/national/ui/germancredittransferedit.ui
> 5c0b7ff818d95482e10a1d3b052b25ed275849d3
> kmymoney/plugins/onlinetasks/sepa/CMakeLists.txt
> 3c2d9db16c1e3ee3a44f21e008bb1ef884cbb8fb
> 
> Diff: https://git.reviewboard.kde.org/r/130135/diff/
> 
> 
> Testing
> -------
> 
> Successfully builds again with the patch (there was a moc error after
> upgrade to boost-1.63).