Review Request 129116: Fix 'Exported templates does not have any title and description'.

[Ralf Habacker]

> On Nov. 27, 2016, 9:27 vorm., Thomas Baumgart wrote:
> > kmymoney/kmymoney.cpp, line 2185
> > <https://git.reviewboard.kde.org/r/129116/diff/2/?file=481815#file481815line2185>
> >
> >     Does https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0 apply if you don't assign a parent object to the dialog? I am not sure hence I am asking.
> >     
> >     It might also be good to compare the return value with QDialog::Accepted which makes the code more readable.

Application did not crash killing kmymoney by qdbus with open dialog but to be sure I updated the patch. Please review


- Ralf


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129116/#review101134
-----------------------------------------------------------


On Mai 22, 2017, 9:04 vorm., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129116/
> -----------------------------------------------------------
> 
> (Updated Mai 22, 2017, 9:04 vorm.)
> 
> 
> Review request for KMymoney and Thomas Baumgart.
> 
> 
> Bugs: 370224
>     http://bugs.kde.org/show_bug.cgi?id=370224
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Before exporting a dialog is now shown with which users can fill
> in title, short and long description.
> 
> BUG:370224
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneytemplate.h 888178b 
>   kmymoney/converter/mymoneytemplate.cpp b90adb0 
>   kmymoney/dialogs/CMakeLists.txt 0daa6f6 
>   kmymoney/kmymoney.cpp fc12a36 
> 
> Diff: https://git.reviewboard.kde.org/r/129116/diff/
> 
> 
> Testing
> -------
> 
> tested on 4.8 branch
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170522/d98cc37f/attachment.html>