Review Request 129796: Fix sql database generation via tools->generate database sql

Marc Hübner mahueb55 at gmail.com
Fri Jun 16 17:30:18 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129796/
-----------------------------------------------------------

(Updated June 16, 2017, 7:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney.


Changes
-------

Submitted with commit b4061d79fd6d205dcd1f85ec5528c1027f7fe1ad by Thomas Baumgart to branch master.


Repository: kmymoney


Description
-------

query parameters are being matched only based on their name. If one parameter starts with the name of another, this leads to conflicts, e.g. :payeeId and :payeeIdentifier --> if both matches are replaced by NULL, this results in the second match being replaced to NULLentifier, which is obviously not intended.


Diffs
-----

  kmymoney/mymoney/storage/mymoneydbdef.cpp 1474a06 

Diff: https://git.reviewboard.kde.org/r/129796/diff/


Testing
-------

manually executed the rendered SQL statements in Mysql to create the database tables.


Thanks,

Marc Hübner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170616/6bb8fa43/attachment.html>


More information about the KMyMoney-devel mailing list