Severe bug in reports in master branch

[Cristian Oneț]

While I'm at it here's another reporting related crash. Since it only
affects files that have some kind of budgets defined and display
budget related warning on the home view I added a test budget to the
file. Pleas try to reach the home view with the buget section shown.
It will result in a crash at this line [1]. I agree the code is not
the prettiest but it was probably based on a budget report assertion
which is no longer valid. I intended to fix it myself but I'm
currently running a system update (on gentoo if you have not done that
for a year it takes a while :)).

[1] https://cgit.kde.org/kmymoney.git/tree/kmymoney/views/khomeview.cpp#n1539

2017-06-12 22:57 GMT+03:00 Cristian Oneț <onet.cristian at gmail.com>:
> 2017-06-12 19:50 GMT+03:00 Łukasz Wojniłowicz <lukasz.wojnilowicz at gmail.com>:
>> Hi Cristian,
>> don't be upset about bugs. It's either no development or bugs. You can help
>> yourself by writing test cases - I try not to break them.
>
> I understand that, I'm kind of amazed that the formatting issue did
> not have a test to catch it since reports do have some unit tests.
>
>> The issue you referred to was rather massive code change and no simple bug fix,
>> so better it be well tested.
>> I'm glad that you test the latest version and report bugs. About bugs:
>>
>> 1) order by date
>> Are you sure this was working in the past?
>
> I'm positive, in fact I'm so sure that I always took this behavior for
> granted, today when I needed to create a report after I changed some
> transaction dates at first I was like: what in the world is going on
> !??
>
>> What does it mean to close and open the file? Isn't it enough to reopen the
>> report?
>
> If it would have been enough I would not have reported it as "severe".
>
>> Can you provide test file?
>
> Attached, steps to reproduce:
> 1. Open the transactions by account report
> 2. Change a transaction date
> 3. Observe that the order is wrong
> 4. Close the report
> 5. Reopen it and observe that the order is still wrong
> 6. Save the file and repeat steps 4,5 with the same result
>
>>
>> 2) annoying nitpick
>> That would require well described bug report because I understand nothing. I
>> tried to do as you write but have no problem in setting dates to one month and
>> keeping it afterwards.
>> I know a little bug with relative date setting but I believe it's not related
>> and rather easy to fix (patch about to come)
>
> See attached screenshots, the combo is "User defined" until I select
> 31.05.2017 the it automatically switches to the "Last month", but I
> don't want that because the last month is relative, I want to keep it
> absolute, the report for May should always show data from May.
>
>>
>> 3) screenshot
>>
>> Do you need all those total rows on this particular report?
>
> You mean 2 totals, why not?
>
>>
>> Regards
>> Łukasz
>>
>> Dnia poniedziałek, 12 czerwca 2017 05:54:41 CEST Cristian Oneț pisze:
>>> Hi,
>>>
>>> I wasn't able to follow the developments in the last 6 months but I
>>> still do updates from time to time. I understand that work is being
>>> done on the reports but I also encountered some, as you say, severe
>>> bugs in that area. One of them was transaction amount formatting [1]
>>> (seems to have been fixed, at least with "Convert to base currency"
>>> checked). Another recent bug is that transactions are not ordered by
>>> date anymore, if transaction dates are edited after a report is opened
>>> (one has to close/open the file to get the new order), see attached
>>> image (27.05, 22.05, 29.05). Another one is a nitpick but an annoying
>>> one, if I need to create a report for the last month but I want to use
>>> the absolute timeframe selection (to keep it on that month forever) I
>>> can't because the relative "Last month" overwrites my choice thus
>>> breaking my report a month from now.
>>>
>>> I know that I should open a bug for each of these but this is all I
>>> can do for now.
>>>
>>> Regards,
>>> Cristian
>>>
>>> [1] https://phabricator.kde.org/D4656
>>>
>>> 2017-05-31 22:58 GMT+03:00 Christian David <christian-david at web.de>:
>>> > Hello,
>>> >
>>> > I just noticed a severe bug in the reports which is probably not very old.
>>> > In a tax report I ordered the transactions by category. However, in a
>>> > category a split is shown which has a different category but another
>>> > split of the transaction is in that category.
>>> >
>>> > Has somebody change something is this area?
>>> >
>>> > Best
>>> > Chris
>>
>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: report-test.kmy
Type: application/x-kmymoney
Size: 1186 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170612/9469a242/attachment.bin>