Review Request 130143: adds support to use a dedicated opening balance account.

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130143/#review103286
-----------------------------------------------------------



I think the ones now are just nitpicks and not major stones in our/your path. I just wanted to mention them. I leave it up to you to improve or leave as is.


kmymoney/dialogs/knewaccountdlg.cpp (line 897)
<https://git.reviewboard.kde.org/r/130143/#comment68712>

    One could also continue in case the accountType is not Equity, but that's just a minor improvement.



kmymoney/dialogs/knewaccountdlg.cpp (line 900)
<https://git.reviewboard.kde.org/r/130143/#comment68711>

    One more nitpick: you could stop scanning here with a break statement.



kmymoney/mymoney/mymoneyfile.cpp (line 1134)
<https://git.reviewboard.kde.org/r/130143/#comment68713>

    This will not work once the first time a user adds an open paren to the name of an opening balance account. But I guess it will not hurt because the user can move the new opening balance account around once created anyway. So we don't think further at this point - at least I don't.



kmymoney/dialogs/knewaccountdlg.h (line 153)
<https://git.reviewboard.kde.org/r/130143/#comment68714>

    Does this really need to be a SLOT? It's just called directly, at least I did not spot a connection to it. It does not hurt, but saves a few bytes of memory.


- Thomas Baumgart


On Juni 5, 2017, 6:02 nachm., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130143/
> -----------------------------------------------------------
> 
> (Updated Juni 5, 2017, 6:02 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 370290
>     http://bugs.kde.org/show_bug.cgi?id=370290
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> With recent implementation kmymoney is not able to use a
> dedicated account for opening balances. Instead it (creates)
> and uses an opening balance account with the translated name
> of "Opening Balances" which may be language specific.
> 
> To specify an opening balance account to be used on adding new
> accounts one way of operation is to set the "opening balance
> account" flag in the account editor for equity accounts.
> 
> This is enabled if no other account contains this flag. Also
> changing the state of the flag is only possible if no transactions
> are assigned to the account having this flag.
> 
> Another way to use this support is to flag an opening balance
> account in a kmymoney account template file.
> 
> On creating a new kmymoney file the "opening balance account"
> flag is imported from a template account flag if specified
> in the following form:
> 
> <account type="16" name="9000 Saldovortragskonten">
>    <flag name="OpeningBalanceAccount"/>
> </account>
> 
> The template admin needs to make sure that only one template account
> has this flag set.
> 
> Exporting the current kmymoney file to an account template exports
> this flag too.
> 
> If there is at least one dedicate opening balance account in a kmymoney
> file the name will be used as template for adding additional currency
> related opening balance accounts in the same hierachy level as the
> referenced opening balance account.
> 
> BUG:370290
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneytemplate.cpp 25a343e3fbdd9409ebdbd814bc08122c151a09d9 
>   kmymoney/dialogs/knewaccountdlg.h 58c8efe08cd03f9e683559f0afb2525b74d36f07 
>   kmymoney/dialogs/knewaccountdlg.cpp dfe2967174bf323d9eda4983fd545d0930a9ec43 
>   kmymoney/dialogs/knewaccountdlgdecl.ui bee638d2b4f73bc8496c86bbf606bfaa5fa4c913 
>   kmymoney/kmymoney.cpp 0d7311a34db307a89c55b0e296fbbc13989d8844 
>   kmymoney/mymoney/mymoneyfile.cpp 692014b21ec8bff4e4c3f3f240d377cd7b9697b3 
>   kmymoney/mymoney/storage/mymoneystorageanon.cpp b6d0dc6a7b499aa45498cb76bef836731ff618d4 
>   kmymoney/reports/objectinfotable.cpp 584a9a378d37d51766e551d8e6b6baffe4fb397d 
>   kmymoney/reports/reportstestcommon.h 22000165dff793c5d7281072f702e0ca3c40f882 
>   kmymoney/reports/reportstestcommon.cpp 40b103ca965e0a1973b6fd0a351ddb976aa10471 
>   kmymoney/templates/de_DE/skr03.kmt 8ab66033ea04f29cd5c50cf567eca654b0a82f57 
>   kmymoney/templates/de_DE/skr04.kmt d3b963608369cac50a67dea79349ccf2ec0289f0 
> 
> Diff: https://git.reviewboard.kde.org/r/130143/diff/
> 
> 
> Testing
> -------
> 
> - compiled
> - set/unset "opening balance account" flag in account editor for a given account and save/load kmymoney file -> state is persistent
> - checked if it is possible to set "opening balance account" flag in an additional account -> check box is not visible on editing the second account
> - checked if it is possible to change "opening balance account" flag if transactions are assigned to the opening balance account -> check box is disabled
> 
> Note: I choosed the flag name as to be 'OpeningBalanceAccount' in the template file and kmymoney file to have the same name.
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170605/122e06a6/attachment-0001.html>