Review Request 130143: This patch introduce a feature to specify a dedicated account to be used as opening balance account instead of using an account with a predefined name which may be language specific.

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130143/#review103283
-----------------------------------------------------------




kmymoney/dialogs/knewaccountdlg.cpp (line 232)
<https://git.reviewboard.kde.org/r/130143/#comment68709>

    One more thing that just crosses my mind: you need to check that the security of the account is the same. Each security must have its own opening balance account.
    
    So in fact, since you are about to create an account, this becomes dynamic as you could change the security of the opening balance account during the course of the activity which might have an influence on the availability of this option.
    
    Convert this logic into a slot and call it if the security changes. Also, I would lock the security once this option is enabled.



kmymoney/dialogs/knewaccountdlg.cpp (line 243)
<https://git.reviewboard.kde.org/r/130143/#comment68708>

    'Option has been disabled ...' would be a better wording


- Thomas Baumgart


On Juni 5, 2017, 2:34 nachm., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130143/
> -----------------------------------------------------------
> 
> (Updated Juni 5, 2017, 2:34 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 370290
>     http://bugs.kde.org/show_bug.cgi?id=370290
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> The "opening balance account" flag could be set in the account
> editor if no other account contains this flag. Also changing
> the state of the flag is only possible if no transactions are
> assigned to the account having this flag.
> 
> On creating a new kmymoney file the "opening balance account"
> flag is imported from a related template account flag if specified
> in the following form:
> 
> <account type="16" name="9000 Saldovortragskonten">
>    <flag name="OpeningBalanceAccount" value="1"/>
> </account>
> 
> If specified the template admin needs to make sure that only one
> template account has this flag set.
> 
> Exporting the current kmymoney file to an account template exports
> this flag too.
> 
> BUG:370290
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneytemplate.cpp 25a343e3fbdd9409ebdbd814bc08122c151a09d9 
>   kmymoney/dialogs/knewaccountdlg.cpp dfe2967174bf323d9eda4983fd545d0930a9ec43 
>   kmymoney/dialogs/knewaccountdlgdecl.ui bee638d2b4f73bc8496c86bbf606bfaa5fa4c913 
>   kmymoney/kmymoney.cpp 0d7311a34db307a89c55b0e296fbbc13989d8844 
>   kmymoney/mymoney/mymoneyfile.cpp 692014b21ec8bff4e4c3f3f240d377cd7b9697b3 
>   kmymoney/mymoney/storage/mymoneystorageanon.cpp b6d0dc6a7b499aa45498cb76bef836731ff618d4 
>   kmymoney/reports/objectinfotable.cpp 584a9a378d37d51766e551d8e6b6baffe4fb397d 
>   kmymoney/reports/reportstestcommon.h 22000165dff793c5d7281072f702e0ca3c40f882 
>   kmymoney/reports/reportstestcommon.cpp 40b103ca965e0a1973b6fd0a351ddb976aa10471 
>   kmymoney/templates/de_DE/skr03.kmt 8ab66033ea04f29cd5c50cf567eca654b0a82f57 
>   kmymoney/templates/de_DE/skr04.kmt d3b963608369cac50a67dea79349ccf2ec0289f0 
> 
> Diff: https://git.reviewboard.kde.org/r/130143/diff/
> 
> 
> Testing
> -------
> 
> - compiled
> - set/unset "opening balance account" flag in account editor for a given account and save/load kmymoney file -> state is persistent
> - checked if it is possible to set "opening balance account" flag in an additional account -> check box is not visible on editing the second account
> - checked if it is possible to change "opening balance account" flag if transactions are assigned to the opening balance account -> check box is disabled
> 
> Note: I choosed the flag name as to be 'OpeningBalanceAccount' in the template file and kmymoney file to have the same name.
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170605/e72c43cf/attachment.html>