Review Request 129831: Optimize KReportChartView::drawPivotChart

[Łukasz Wojniłowicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129831/
-----------------------------------------------------------

(Updated Jan. 22, 2017, 4:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney.


Changes
-------

Submitted with commit 14e50c73a43102b38919106311685c366c908ddb by ?ukasz Wojni?owicz to branch master.


Repository: kmymoney


Description
-------

1) setCellTip merged into setDataCell,
2) don't set up model with tooltips if ChartDataLabels is false,
3) run justifyModelSize only once for each dataset,
4) check coordinatePlane()->diagram()->datasetDimension() only once for
each dataset,
5) use setItemData instead of setData.


Diffs
-----

  kmymoney/reports/kreportchartview.h 25216a2 
  kmymoney/reports/kreportchartview.cpp ce274bd 

Diff: https://git.reviewboard.kde.org/r/129831/diff/


Testing
-------

Investment Price Graph and other line graphs.


Thanks,

Łukasz Wojniłowicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170122/4e7339ba/attachment.html>