Review Request 129848: Set correct ServiceTypes for plugins

[Łukasz Wojniłowicz]

> On Sty 17, 2017, 11:07 rano, Thomas Baumgart wrote:
> > It does not solve a problem I have here, but it seems to be logical to me.
> 
> Łukasz Wojniłowicz wrote:
>     If your problem is that you still don't have plugins visible, then try clean compilation. This patch somehow doesn't trigger need for recompilation.
> 
> Thomas Baumgart wrote:
>     Resolved my problem: it was not only the compilation but the plugin also needed to be 'installed'. I still had an old version which was picked up. So please 'Ship it!'

Good. I would like to ship it at once with rest of my patches. I'll wait for positive review or ship them unconditionally next weekend.


- Łukasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129848/#review102073
-----------------------------------------------------------


On Sty 16, 2017, 4:11 po południu, Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129848/
> -----------------------------------------------------------
> 
> (Updated Sty 16, 2017, 4:11 po południu)
> 
> 
> Review request for KMymoney and Christian David.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> It makes plugins in File->Import/Export menu visible again.
> 
> 
> Diffs
> -----
> 
>   kmymoney/plugins/csvexport/csvexport.json.in 2265e08 
>   kmymoney/plugins/csvimport/csvimport.json.in d1cadab 
>   kmymoney/plugins/ofximport/ofximport.json.in 422c1ad 
> 
> Diff: https://git.reviewboard.kde.org/r/129848/diff/
> 
> 
> Testing
> -------
> 
> Starting CSV Importer plugin.
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170121/d1170a60/attachment.html>