Review Request 129739: Revise investment performance report

[Łukasz Wojniłowicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129739/
-----------------------------------------------------------

(Updated Jan. 8, 2017, 8:34 p.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney.


Changes
-------

Submitted with commit 88173ce91714e57464b4db586eb3e395fd8e85cb by ?ukasz Wojni?owicz to branch master.


Repository: kmymoney


Description
-------

1) "amount" (last column) has been replaced by "ending balance" because
it's calculated specially for this report by
QueryTable::constructPerformanceRow,
2) "return on investment" column is being calculated also when "ending
balance" is zero, because zero ending balance doesn't invalidate ROI
3) "buys" and "sells" column take "fee amounts" into account during ROI
calculation, because fees are inseparable from investments,
4) "buys" column has minus sign and "sells" column has plus sing,
because the same notatnion is used by KMM importers.


Diffs
-----

  kmymoney/reports/listtable.cpp 72b605f 
  kmymoney/reports/querytable.cpp e44f74c 

Diff: https://git.reviewboard.kde.org/r/129739/diff/


Testing
-------

Reports on stock securities with dividends, completely, partially and not sold at all.


Thanks,

Łukasz Wojniłowicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170108/da22b22f/attachment.html>