Review Request 129794: Port KReportsView::slotSaveView to KF5

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129794/#review101889
-----------------------------------------------------------



Please fix the dialog issue and then ship it w/o further review.


kmymoney/views/kreportsview.cpp (line 705)
<https://git.reviewboard.kde.org/r/129794/#comment68160>

    This should better read
    
     if((dialog->exec() == QDialog::Accepted) && dialog)
     
    to avoid crashes when the application is quit during the execution of the dialog.


- Thomas Baumgart


On Jan. 8, 2017, 5:32 nachm., Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129794/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2017, 5:32 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Saving reports is available again.
> 
> 
> Diffs
> -----
> 
>   kmymoney/views/kreportsview.cpp c9c9a12 
> 
> Diff: https://git.reviewboard.kde.org/r/129794/diff/
> 
> 
> Testing
> -------
> 
> Tried to save couple of CSV and HTML reports.
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170108/f9edf75b/attachment.html>