Review Request 129371: Use GpgME++ if possible, QGpgme from kdepimlibs-4 as fallback

Andreas Sturmlechner andreas.sturmlechner at gmail.com
Sun Jan 1 23:19:49 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129371/
-----------------------------------------------------------

(Updated Jan. 1, 2017, 11:19 p.m.)


Review request for KMymoney.


Changes
-------

rebased on top of recent changes. anyone who wants to ship this for 4.8.1?


Summary (updated)
-----------------

Use GpgME++ if possible, QGpgme from kdepimlibs-4 as fallback


Repository: kmymoney


Description (updated)
-------

Remove bogus qgpgme include.

REVIEW: 129371

Make kdepimlibs optional

Based on b5de50ccaa1571c4feb0c17ea8016554e3b822d7 from master.

REVIEW: 129371


Diffs (updated)
-----

  CMakeLists.txt 22515185dcb2bdb6a9027101270ff97d445008b6 
  kmymoney/dialogs/settings/ksettingsschedules.cpp da138a7ab138d2f5ef1e8f5b7ad636f9a1964343 
  kmymoney/kmymoney.cpp 3b3352b7abc83b60fe0e8156d48e7be439fb8964 
  libkdchart/kdablibfakes/src/KDABLibFakes.h f47ec24423a2ca61b04a98069351539e738fe572 
  libkgpgfile/CMakeLists.txt a41a6a408e3da8769308dae75d4f514aa969dc87 
  libkgpgfile/kgpgfile.cpp b1870be92edb833ed30f369e3e0ca0f320fe147b 

Diff: https://git.reviewboard.kde.org/r/129371/diff/


Testing
-------

Built successfully (so far only tested with GpgME++ 1.7.1 and without kdepimlibs-4).
Also built fine on a system with Gpgme 1.7.1 (no Gpgmepp bindings) and kdepimlibs-4 installed.


Thanks,

Andreas Sturmlechner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170101/3586539a/attachment.html>


More information about the KMyMoney-devel mailing list