Review Request 130236: Make Qt4 build support working again by specifing -DBUILD_QT4=1 on cmake configure line

Ralf Habacker ralf.habacker at freenet.de
Tue Aug 29 07:50:49 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130236/
-----------------------------------------------------------

(Updated Aug. 29, 2017, 9:50 vorm.)


Review request for KMymoney and Skrooge.


Changes
-------

- fix variable name (used ALKIMIA_PATH_SUFFIX to indicate that it is provided by alkimia and not cmake)
- The '>>>>' markers seems to be a reviewboard issue because the downloaded patch does not include any tabs


Repository: alkimia


Description (updated)
-------

The installed package is coinstallable with the Qt5 variant.
See README.md for more details how to use.

Required for building stable kmymoney releases, which are Qt4 based.

REVIEW:130236


Diffs (updated)
-----

  CMakeLists.txt 19f3e4d367324841e12b426ae9cadc127aa0e597 
  README.md PRE-CREATION 
  autotests/CMakeLists.txt faa9973d750503cb5ef017c70a0b4a29181ab5dd 
  src/CMakeLists.txt 9765cf7c43e5c09fe20c7a6ac1b872718eeac781 
  src/LibAlkimiaConfig.cmake.in cce2f7c420109d981f21866b0ed57bdf7ae834f8 
  src/libalkimia.pc.in 871e3f30ac0ead437b84707506d3b8d770d9f007 

Diff: https://git.reviewboard.kde.org/r/130236/diff/


Testing
-------

- compiled for qt4 and qt5
- used to build with kmymoney4 and kmymoney/KF5


Thanks,

Ralf Habacker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170829/3b35d86f/attachment.html>


More information about the KMyMoney-devel mailing list