Review Request 130234: Fix 'Missing buttons for adding/removing entries in currency edit dialog'

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130234/#review103648
-----------------------------------------------------------




kmymoney/dialogs/kcurrencyeditdlg.cpp (line 289)
<https://git.reviewboard.kde.org/r/130234/#comment68969>

    Why don't you connect the resp. signal directly to newCurrency, e.g.
    
      connect(this, SIGNAL(user3Clicked()), this, SIGNAL(newCurrency()));
      
    This way, you don't need the slotNewCurrency() at all.


- Thomas Baumgart


On Aug. 22, 2017, 10:49 vorm., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130234/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2017, 10:49 vorm.)
> 
> 
> Review request for KMymoney and Jack Ostroff.
> 
> 
> Bugs: 383831
>     http://bugs.kde.org/show_bug.cgi?id=383831
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Patch adds requested buttons
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/kcurrencyeditdlg.h 712420304caf55a1ae762a6d715568a908de4fc0 
>   kmymoney/dialogs/kcurrencyeditdlg.cpp 58b7c20c083a73730dedd4faa3607b89c5dd00ca 
>   kmymoney/kmymoney.cpp 9c372746c658d9562dfde1eec25a472e95a81ebe 
> 
> Diff: https://git.reviewboard.kde.org/r/130234/diff/
> 
> 
> Testing
> -------
> 
> - branch compiled
> - tested adding entry
> - tested removing entry
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170824/4ea83340/attachment.html>