Review Request 130233: Fixup for 'OFX import Online Statement Balance error'

[Ralf Habacker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130233/
-----------------------------------------------------------

(Updated Aug. 21, 2017, 10:44 p.m.)


Review request for KMymoney.


Changes
-------

Fix remaining setup of "lastStatementDate" on ofx importer - "lastStatementDate" key/value pair is still used for writing into xml file because last reconcilation date is written as part of key value pairs into accounts


Bugs: 323480
    http://bugs.kde.org/show_bug.cgi?id=323480


Repository: kmymoney


Description (updated)
-------

The background is that it was unclear what to use MyMoneyAccount::setValue("lastStatementDate") or MyMoneyAccount::setLastReconcilationDate()

Thomas suggests to use the latter, but there is a location in code using code variant 1 which is fixed also with this commit.


Diffs (updated)
-----

  kmymoney/converter/mymoneyqifreader.cpp 36b865cf142e912cb0db57d5f1a8f5b1f64aa53c 
  kmymoney/converter/mymoneystatementreader.cpp e2ea3f820a75238c79dfb6cbef685a2dd60b3cfe 
  kmymoney/mymoney/mymoneyaccount.cpp 46be12dfb30daa7a29f88e4de8bebc13d178d526 

Diff: https://git.reviewboard.kde.org/r/130233/diff/


Testing
-------


Thanks,

Ralf Habacker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170821/09cc1c6a/attachment-0001.html>