[kmymoney/4.8] /: Another cmake fix.

[Thomas Baumgart]

Hi all,

On Friday 30 September 2016 10:57:07 Jack wrote:

> On 2016.09.30 05:29, Christian Dávid wrote:
> > Hi Ralf,
> > 
> > I think it should be
> > 
> > if (${LibAlkimia_FOUND} AND DEFINED LibAlkimia_VERSION)
> > 
> > without ${}. This explains why you had an error if LibAlkimia_VERSION
> > is not defined — because the expresion evaluates to "if
> > (${LibAlkimia_FOUND} AND DEFINED)".
> > 
> > Also I want to highlight that Alkimia 6 uses the version parameter of
> > find_package(). If there is something lower than version 6 required,
> > it aborts. The find modules should not care about that additional
> > parameter (unfortunatly I cannot test this because I cannot compile
> > the 4.8 branch at the moment). So the whole test logic is not needed
> > anymore.
> > 
> > Greetings
> > Christian
> > 
> > P.S.: @Thomas, I know this branch is at its end of lifetime. However,
> > this seems to be more work than thought.
> 
> Unfortunately, I think maintaining this branch is absolutely necessary
> until the Frameworks version is complete and considered stable enough
> for general use.

Yes, that is what we are trying to achieve.

[...]


> I'm really happy to see these changes, as I just got caught by this
> yesterday :-)  I can confirm that the current version in git completes
> the cmake.  It's compiling now.

Cool. And the current version looks very close to what I have commited in 
cdaf1112c14d7c7ad1b1a609585a65385e8ca2c3 ;) and it works for me also.


-- 

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
If Windows is the answer I want my problem back!
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 225 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160930/0c0f997d/attachment.sig>