Review Request 129003: Separate investment page

Łukasz Wojniłowicz lukasz.wojnilowicz at
Sun Sep 25 08:22:27 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated Wrz 25, 2016, 10:22 rano)

Review request for KMymoney.

Repository: kmymoney


csvwizard.cpp has many lines of code, so it's good to separate
investment page from it. The outcome is:

1) m_pageInvestment is initialized only when it's needed,
2) combo boxes on m_pageInvestment are initialized only when needed,
3) removed registered fields, because there is no need to use them on
other pages,
4) merged investprocessing with investmentwizardpage, so there is no
ping-pong communication between them
5) used only one slot for every combo box,
6) removed name and security filter lineedits, because they aren't
essential/usefull to import,
7) removed redundant includes,
8) clear button causes fees also to be cleared,
9) clear fee column right before user goes back to rows page,
10) changed operation lists initialization to facilitate translation,
11) don't update window size if m_pageInvestment isn't visible, because
it won't work correctly,
12) tidied up names and structure of investmentwizardpage.

Diffs (updated)

  kmymoney/plugins/csvimport/CMakeLists.txt 04664f3 
  kmymoney/plugins/csvimport/csvimporterplugin.h 847d5b8 
  kmymoney/plugins/csvimport/csvimporterplugin.cpp c4478f4 
  kmymoney/plugins/csvimport/csvwizard.h 1c75de6 
  kmymoney/plugins/csvimport/csvwizard.cpp db6e571 
  kmymoney/plugins/csvimport/investmentwizardpage.h PRE-CREATION 
  kmymoney/plugins/csvimport/investmentwizardpage.cpp PRE-CREATION 
  kmymoney/plugins/csvimport/investmentwizardpage.ui 3b4d6a2 
  kmymoney/plugins/csvimport/investprocessing.h 87b5512 
  kmymoney/plugins/csvimport/investprocessing.cpp 860ca77 
  kmymoney/plugins/csvimport/redefinedlg.h 688725e 
  kmymoney/plugins/csvimport/redefinedlg.cpp 58fa625 




Łukasz Wojniłowicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KMyMoney-devel mailing list