Review Request 128874: Free QFileDialog memory

[Łukasz Wojniłowicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128874/
-----------------------------------------------------------

(Updated Sept. 16, 2016, 4:38 p.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney.


Changes
-------

Submitted with commit c9bad8d1434ff8f80d91bcf3d10a77b4343c5b3a by ?ukasz Wojni?owicz to branch master.


Repository: kmymoney


Description
-------

After closing CSV Importer in the middle and then KMyMoney, I get "The program has unexpectedly finished".
The problem doesn't occur if CSV Importer goes all way through to the last page; then I can go back and close it wherever I want.
If I comment out this line, there is no problem at all.
```c++
  QPointer<QFileDialog> dialog = new QFileDialog(this, QString(),
                                                 fileInfo.absoluteFilePath(),
                                                 i18n("*.csv *.PRN *.txt | CSV Files\n *|All files"));
```
Memory on which dialog pointed wasn't deleted in the method and it obviously need to be deleted, but the problem remains. Does anyone know how to prevent QtCreator from showing "The program has unexpectedly finished" here?


Diffs
-----

  kmymoney/plugins/csvimport/csvwizard.h ecec5b0 
  kmymoney/plugins/csvimport/csvwizard.cpp b576dea 

Diff: https://git.reviewboard.kde.org/r/128874/diff/


Testing
-------


Thanks,

Łukasz Wojniłowicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160916/1857c783/attachment.html>