Review Request 128875: Add account autodetecting to CSV Importer

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128875/#review99050
-----------------------------------------------------------




kmymoney/plugins/csvimport/csvwizard.cpp (line 529)
<https://git.reviewboard.kde.org/r/128875/#comment66699>

    Please use braces here.



kmymoney/plugins/csvimport/csvwizard.cpp (line 542)
<https://git.reviewboard.kde.org/r/128875/#comment66701>

    Please use
    
      if(filteredAccounts.count() > 1)
      
    I know that count() and length() are identical here, but we use count() throughout the application in all other spots.



kmymoney/plugins/csvimport/csvwizard.cpp (line 558)
<https://git.reviewboard.kde.org/r/128875/#comment66700>

    Please use
    
      if(filteredAccounts.isEmpty())



kmymoney/plugins/csvimport/csvwizard.cpp (line 598)
<https://git.reviewboard.kde.org/r/128875/#comment66702>

    Please use count() instead of length().


- Thomas Baumgart


On Sept. 10, 2016, 11:55 vorm., Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128875/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2016, 11:55 vorm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Presented autodetecting mechanism scans statement header and tries to
> find name (or number, in case it fails) of user accounts. In case it
> finds multiple account matches, filtering by account numbers occurs.
> Benefit:
> User isn't asked about selecting account right before statement import.
> 
> 
> Diffs
> -----
> 
>   kmymoney/plugins/csvimport/csvdialog.cpp 1a0ec93 
>   kmymoney/plugins/csvimport/csvwizard.h 136a48b 
>   kmymoney/plugins/csvimport/csvwizard.cpp 7019747 
>   kmymoney/plugins/csvimport/investprocessing.cpp 7f0c624 
> 
> Diff: https://git.reviewboard.kde.org/r/128875/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160910/720f77b7/attachment.html>