Review Request 128876: Handle CSV Importer exits the right way

Thomas Baumgart tbaumgart at kde.org
Sat Sep 10 10:20:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128876/#review99049
-----------------------------------------------------------


Ship it!




Ship It!

- Thomas Baumgart


On Sept. 10, 2016, 11:58 vorm., Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128876/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2016, 11:58 vorm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> 1) restore eventFilter only this time it's working right,
> 2) after pressing cancel button, CSV Wizard should close without any
> save,
> 3) CSV Wizard window should be modal and closed before main window.
> 
> 
> Diffs
> -----
> 
>   kmymoney/plugins/csvimport/csvwizard.h 136a48b 
>   kmymoney/plugins/csvimport/csvwizard.cpp 7019747 
>   kmymoney/plugins/csvimport/csvwizard.ui c278932 
> 
> Diff: https://git.reviewboard.kde.org/r/128876/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160910/e78ab259/attachment.html>


More information about the KMyMoney-devel mailing list