Review Request 128873: Add configuration dialog for CSV Importer

[Thomas Baumgart]

> On Sept. 10, 2016, 7:52 vorm., Thomas Baumgart wrote:
> > kmymoney/plugins/csvimport/CMakeLists.txt, line 59
> > <https://git.reviewboard.kde.org/r/128873/diff/1/?file=476625#file476625line59>
> >
> >     Please remove leftover whitespace char(s)
> 
> Łukasz Wojniłowicz wrote:
>     It's done. Do you see any other issues, that should be corrected before commiting it?

No, except the one with the size.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128873/#review99041
-----------------------------------------------------------


On Sept. 10, 2016, 10:05 vorm., Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128873/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2016, 10:05 vorm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Although autodetecting features were tested multiple ways, they may
> cause troubles on another data sets. Give user the possibility to
> disable potential troublemakers.
> 
> 
> Diffs
> -----
> 
>   kmymoney/plugins/csvimport/CMakeLists.txt 216c79c 
>   kmymoney/plugins/csvimport/kcm_csvimport.h PRE-CREATION 
>   kmymoney/plugins/csvimport/kcm_csvimport.cpp PRE-CREATION 
>   kmymoney/plugins/csvimport/kcm_kmm_csvimport.desktop PRE-CREATION 
>   kmymoney/plugins/csvimport/pluginsettings.kcfg PRE-CREATION 
>   kmymoney/plugins/csvimport/pluginsettings.kcfgc PRE-CREATION 
>   kmymoney/plugins/csvimport/pluginsettingsdecl.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128873/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> configuration dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/09/50f42b98-e239-465b-bf63-21fdd1a42304__Configuration.png
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160910/48f1cf33/attachment.html>