Review Request 128873: Add configuration dialog for CSV Importer

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128873/#review99041
-----------------------------------------------------------



Regarding the initial window size: why should that be a setting for the user? We can provide it with the application and simply store whatever the user changed it to. This way, we gain more functionality (the user can control the size and this setting is automatically kept for the next run) by reducing the number of options. See QWidget::saveGeometry() for details. Or simply store the width and height as it is done in the ctor/dtor of KSplitTransactionDlg().


kmymoney/plugins/csvimport/CMakeLists.txt (line 59)
<https://git.reviewboard.kde.org/r/128873/#comment66690>

    Please remove leftover whitespace char(s)


- Thomas Baumgart


On Sept. 9, 2016, 6:01 nachm., Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128873/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2016, 6:01 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Although autodetecting features were tested multiple ways, they may
> cause troubles on another data sets. Give user the possibility to
> disable potential troublemakers.
> 
> 
> Diffs
> -----
> 
>   kmymoney/plugins/csvimport/CMakeLists.txt 216c79c 
>   kmymoney/plugins/csvimport/kcm_csvimport.h PRE-CREATION 
>   kmymoney/plugins/csvimport/kcm_csvimport.cpp PRE-CREATION 
>   kmymoney/plugins/csvimport/kcm_kmm_csvimport.desktop PRE-CREATION 
>   kmymoney/plugins/csvimport/pluginsettings.kcfg PRE-CREATION 
>   kmymoney/plugins/csvimport/pluginsettings.kcfgc PRE-CREATION 
>   kmymoney/plugins/csvimport/pluginsettingsdecl.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128873/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> configuration dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/09/50f42b98-e239-465b-bf63-21fdd1a42304__Configuration.png
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160910/76b4fcf2/attachment.html>