Review Request 129014: Separate banking page

[Łukasz Wojniłowicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129014/
-----------------------------------------------------------

(Updated Oct. 2, 2016, 9:40 a.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney.


Changes
-------

Submitted with commit 72baa2dbe324949b191066c2ed8e232a89e5e3ef by ?ukasz Wojni?owicz to branch master.


Repository: kmymoney


Description
-------

csvwizard.cpp has many lines of code, so it's good to separate banking
page from it. The outcome is:

1) m_pageBanking is initialized only when it's needed,
2) combo boxes on m_pageBanking are initialized only when needed,
3) removed registered fields, because there is no need to use them on
other pages,
4) merged csvdialog with bankingwizardpage, so there is no ping-pong
communication between them,
5) used only one slot for every combo box,
6) removed redundant includes,
7) tidied up names and structure of investmentwizardpage.


Diffs
-----

  kmymoney/plugins/csvimport/CMakeLists.txt 46cdc16 
  kmymoney/plugins/csvimport/bankingwizardpage.h PRE-CREATION 
  kmymoney/plugins/csvimport/bankingwizardpage.cpp PRE-CREATION 
  kmymoney/plugins/csvimport/csvdialog.h d1e935c 
  kmymoney/plugins/csvimport/csvdialog.cpp 9385d9b 
  kmymoney/plugins/csvimport/csvimporterplugin.h e2908e4 
  kmymoney/plugins/csvimport/csvutil.h 108718e 
  kmymoney/plugins/csvimport/csvwizard.h 6fbb858 
  kmymoney/plugins/csvimport/csvwizard.cpp 7f59af7 

Diff: https://git.reviewboard.kde.org/r/129014/diff/


Testing
-------


Thanks,

Łukasz Wojniłowicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20161002/3bb7a309/attachment.html>